DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Dey, Souvik" <sodey@rbbn.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"Xu, Qian Q" <qian.q.xu@intel.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	"Yu, PingX" <pingx.yu@intel.com>
Cc: "xiaolong.ye@intel.com" <xiaolong.ye@intel.com>,
	"xiao.zhang@intel.com" <xiao.zhang@intel.com>,
	"users@dpdk.org" <users@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] Issue with X550 link status
Date: Mon, 9 Mar 2020 17:32:49 +0000
Message-ID: <34fab8c4-f975-ace8-5380-e57cddd3268d@redhat.com> (raw)
In-Reply-To: <DM6PR03MB47776C549C76123D11B3904DCDE50@DM6PR03MB4777.namprd03.prod.outlook.com>

On 04/03/2020 21:22, Dey, Souvik wrote:

Hi Souvik,

> Little more information. It looks like the below X550 nic is broken as the change related to http://patches.dpdk.org/patch/63951/ is not been backported.
> The below patch broken the link status for ixgbevf and the fix was done in the above patch but we have only backported the below patch to 18.11.6 which breaks the ixgbevf link status. When is plan for 18.11.7 or updated 18.11.6 as we should not have a broken release.

Thanks for reporting this. The fix was in a later DPDK release and will
be part of 18.11.7. It is already backported to the 18.11 branch [1].

I am expecting some more backports this week from authors and to create
a RC for 18.11.7 next week. After that, it is dependent on different
companies to validate and what is found during that validation. At the
moment assuming no major issues, I would estimate April 10th.

There is a list of validation-contacts, that I can add you to if you are
using LTS's so you would get the emails about RC's etc and could test
prior to release. Let me know if you are interested.

+ixgbe maintainers and Intel validation team, is there a test that can
be added to prevent future link status issues?


commit 03b69d3c415f084b14833ed911ac9aa2e470b409
Author: Lunyuan Cui <lunyuanx.cui@intel.com>
Date:   Tue Dec 17 06:12:03 2019 +0000

    net/ixgbe: fix link status

    [ upstream commit ff8162cb9571528c006f265a32730a463fd0b886 ]

> --
> Regads,
> Souvik
> From: Dey, Souvik
> Sent: Wednesday, March 4, 2020 4:08 PM
> To: dev@dpdk.org
> Cc: xiaolong.ye@intel.com; xiao.zhang@intel.com; users@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: RE: Issue with X550 link status
> The X550 NIC is of the below device id.
> [root@stdell10 ~]# lspci -nnn | grep -i ether
> 19:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller 10G X550T [8086:1563] (rev 01)
> 19:00.1 Ethernet controller [0200]: Intel Corporation Ethernet Controller 10G X550T [8086:1563] (rev 01)
> 19:10.0 Ethernet controller [0200]: Intel Corporation X550 Virtual Function [8086:1565]
> 19:10.1 Ethernet controller [0200]: Intel Corporation X550 Virtual Function [8086:1565]
> 19:10.2 Ethernet controller [0200]: Intel Corporation X550 Virtual Function [8086:1565]
> 19:10.3 Ethernet controller [0200]: Intel Corporation X550 Virtual Function [8086:1565]
> So the mac_type is ixgbe_mac_X550_vf  in the below case.
> --
> Regards,
> Souvik
> From: Dey, Souvik
> Sent: Wednesday, March 4, 2020 1:17 PM
> To: dev@dpdk.org<mailto:dev@dpdk.org>
> Cc: xiaolong.ye@intel.com<mailto:xiaolong.ye@intel.com>; xiao.zhang@intel.com<mailto:xiao.zhang@intel.com>; users@dpdk.org<mailto:users@dpdk.org>
> Subject: Issue with X550 link status
> Hi All,
>               After upgrading to DPDK 18.11.6 LTS release from 18.11.2 the link_update call for link status update is not working for  X550 NICs SR-IOV enabled. On debugging it looks like the change introduced as a part of this patch is causing the issue.
> https://patches.dpdk.org/patch/62140/
> @@ -4135,6 +4138,10 @@  ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
>               return rte_eth_linkstatus_set(dev, &link);
>        }
> +       esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);
> +       if ((esdp_reg & IXGBE_ESDP_SDP3))
> +              link_up = 0;
> +
>        if (link_up == 0) {
>               if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>                       intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> I can see that the esdp_req is coming as 3735928495(0xDEADBEAF) and due to which the link_up is set to 0 even when ixgbevf_check_link returned link_up as 1. Along with this patch I also see a path_fullchk patch introduced , does that play any role in this ?
> Can someone please let me know if the patch has got some issues or it is behaving correctly and the link_status is failing for valid reason. As mentioned earlier the same HW with same NIC acting in SR-IOV works fine with 18.11.2 DPDK . I am blocked at a customer bug dew to this and any urgent help will be much appreciated.
> --
> Regards,
> Souvik
> -----------------------------------------------------------------------------------------------------------------------
> Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that
> is confidential and/or proprietary for the sole use of the intended recipient.  Any review, disclosure, reliance or
> distribution by others or forwarding without express permission is strictly prohibited.  If you are not the intended
> recipient, please notify the sender immediately and then delete all copies, including any attachments.
> -----------------------------------------------------------------------------------------------------------------------

      parent reply	other threads:[~2020-03-09 17:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 18:16 Dey, Souvik
2020-03-04 21:08 ` Dey, Souvik
2020-03-04 21:22   ` Dey, Souvik
2020-03-06  1:26     ` Zhang, Xiao
2020-03-09 17:32     ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34fab8c4-f975-ace8-5380-e57cddd3268d@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=pingx.yu@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=sodey@rbbn.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=users@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiao.zhang@intel.com \
    --cc=xiaolong.ye@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git