From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id D97CB9ABC for ; Tue, 24 Feb 2015 21:07:24 +0100 (CET) Received: by wghk14 with SMTP id k14so7677058wgh.3 for ; Tue, 24 Feb 2015 12:07:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Q77RJVzAAjXh5MIH76IQe3SuDm7DcOcKC/LJW0Nejv0=; b=U2g6bVu/vpGMpVi9AyJXF7XihX3Q8yPMUJIJWBz7mOigDoY1dg7s1wVoukouBsw1mF rb8ancNuPP4yDdc75BfyUOcDBM12mziIQK2X6UTSJYW/HN2197a6TctuqebNSzBsOMt5 uHx6yv0W9jcQuLQ8Ft58xA6t09ERqbnKn2Se3ay2JoqQ1xmEnwJgFSSTKuCEkPUz0ehm hMlSirrWSbfwzI64St+cRCXdbY06jRLPcnqUA0ZzfJFRJ6NlL7m/cN7hHrx2ASvdU548 2zuT+0X2knOOT3tFgi5ZQb4fUOduHqNUdgth2yJnAt1BEiLARZRR5S10n0hNmeiHEHD6 LC0w== X-Gm-Message-State: ALoCoQlVTydNIhoYla8qiu4aIL5K/BWAAHQ9AFNV3+dkUQaGT9TNCu5YPHocFH2KfOrXiZSt/FWY X-Received: by 10.180.205.243 with SMTP id lj19mr33579096wic.26.1424808444635; Tue, 24 Feb 2015 12:07:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id lx10sm29898533wjb.17.2015.02.24.12.07.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 12:07:23 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Tue, 24 Feb 2015 21:06:51 +0100 Message-ID: <3501387.NqU76YxSK9@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150224111852.42253352@urahara> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <20150224111852.42253352@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 20:07:25 -0000 2015-02-24 11:18, Stephen Hemminger: > On Mon, 23 Feb 2015 23:51:31 +0000 > Thomas Monjalon wrote: > > > 2015-02-05 07:43, Neil Horman: > > > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > > > + > > > > +/** > > > > + * Hierarchical scheduler subport statistics reset > > > > + * > > > > + * @param port > > > > + * Handle to port scheduler instance > > > > + * @param subport_id > > > > + * Subport ID > > > > + * @return > > > > + * 0 upon success, error code otherwise > > > > + */ > > > > +int > > > > +rte_sched_subport_stats_reset(struct rte_sched_port *port, > > > > + uint32_t subport_id); > > > > + > > > > /** > > > > * Hierarchical scheduler queue statistics read > > > > * > > > > @@ -338,6 +353,20 @@ rte_sched_queue_read_stats(struct rte_sched_port *port, > > > > struct rte_sched_queue_stats *stats, > > > > uint16_t *qlen); > > > > > > > > +/** > > > > + * Hierarchical scheduler queue statistics reset > > > > + * > > > > + * @param port > > > > + * Handle to port scheduler instance > > > > + * @param queue_id > > > > + * Queue ID within port scheduler > > > > + * @return > > > > + * 0 upon success, error code otherwise > > > > + */ > > > > +int > > > > +rte_sched_queue_stats_reset(struct rte_sched_port *port, > > > > + uint32_t queue_id); > > > > + > > > Both need to be added to the version map to expose them properly. > > > Neil > > > > Stephen, this patchset is partially acked and could enter in 2.0.0-rc1. > > May you send a v3 addressing comments? Or should I break the serie by > > applying only some of them? Or postpone the serie to 2.1? > > I can resend v3. Wasn't clear that a conclusion was reached. > IMHO read should not clear. Me too. I'm just saying that I cannot apply anything. So you have to decide the strategy to adopt for your patches.