From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE94DA0531; Tue, 4 Feb 2020 12:07:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 386501C012; Tue, 4 Feb 2020 12:07:11 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7261E1BFAB for ; Tue, 4 Feb 2020 12:07:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C9E4720F20; Tue, 4 Feb 2020 06:07:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Feb 2020 06:07:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+PhoGbmQFug+34Z1eeK9H24uoI8bbT7+AJOuwQbGyuE=; b=NUmLt38J8Vc0 OIcvsP7OU3yx18Kou4NqT62WfHaYGQt1aY+U2Gy9hmQtvxNFsUFUKWKmSRz0/iTw zDhm++npo6X/DV5JyzXz3TJShXxpWrFP3wvNL7DF0LZVQLxeuKvTA31L6VAviICf h2YCBbelZfGluuyT70XBItlUYtWCkhw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+PhoGbmQFug+34Z1eeK9H24uoI8bbT7+AJOuwQbGy uE=; b=C+Uh9Y66+9Z0rbrgAMEqFI9xysNBGuRPVnxfEjJF0iCYujPHrgHjIuZdN yMiMde6pZh23MGm6UNtjMxlqfm1L6mM3ncnBcXa97942jk+biE4utZSy6JdfjN9K HwQ1HZZHXhNROTbQX24lgSle8mJ5dbmUKbBUoxHXK+wJEKEJRXQr8Rhr7bSJOclA qUI+0LioVZlqxEn0R4UzPK0eDRz8WMESHhrO0rh5WLX3qddrtRTJu1+gNOzCahZR bxMVa3KCBh7KZxKJL3r/Xxjm9xAWIeev5TwJmmO7mOd+BU+e3wZa5J64a9uAYN9Z /SWIYO+sG5/42KaPNmJw3uWOK6CiA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgeelgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D2C0E328005A; Tue, 4 Feb 2020 06:07:06 -0500 (EST) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula , Gaetan Rivet Cc: dev@dpdk.org, "dev@dpdk.org" , David Marchand , Vamsi Krishna Attunuru , Jerin Jacob Kollanukkaran Date: Tue, 04 Feb 2020 12:07:05 +0100 Message-ID: <3503128.aV6nBDHxoP@xps> In-Reply-To: <9b82a6cd-a286-5a5e-7cef-6d16a4355e06@u256.net> References: <9100295.rMLUfLXkoz@xps> <9b82a6cd-a286-5a5e-7cef-6d16a4355e06@u256.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2020 11:03, Gaetan Rivet: > On 03/02/2020 23:21, Thomas Monjalon wrote: > > 03/02/2020 06:16, Pavan Nikhilesh Bhagavatula: > >> @David Marchand @thomas@monjalon.net > >> > >> Ping? > >> > >> Are there any more changes required for this patch? It's been in queue since last October. > > > > Sorry we have not decided whether it is a good idea or not. > > > > All changes related to probing are very sensitive, > > and we know a big refactoring would be better than stacking > > more and more options and corner cases. > > > > As we are busy with ABI stability stuff, we did not allocate > > enough time to properly think about this feature. > > Please accept our apologies, and let's consider it as > > a high priority for 20.05 cycle. > > > > Hello Thomas, > > This is unfortunate. I pushed Pavan to accept an alternative implementation of this functionality that was less obtrusive, to make the integration smoother. I took care to alleviate those risks from the common path. > > The big refactoring is needed yes, but considering the current path I'm not seeing it happen in 20.05. If that means taking this patch as-is in 20.05 for Marvell users, I'm not sure much is gained from waiting 3 months, except minimal risk avoidance. Yes, life is full of bad decisions and consequences. I still think there is a risk in adding new user expectations, and maintaining some code to workaround unknown issues. The real question here is to know why this patch? Is it to workaround a broken driver? Or to workaround a broken design in EAL and bus drivers?