From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53496A0523; Wed, 1 Jul 2020 03:31:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB7F51BF5B; Wed, 1 Jul 2020 03:30:59 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 193C01BEDD for ; Wed, 1 Jul 2020 03:30:57 +0200 (CEST) IronPort-SDR: 26N37QctyX6pRfXpnSHBxOmGyPgtNeJMoW8gNxFtpZq1iTEKtaQp+nM6vNdp240wajtk+WVSy2 HjtYzPdrQ5pw== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="126530656" X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="126530656" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 18:30:57 -0700 IronPort-SDR: OrH5sfzCTKpaDqir/Q/LOsJmjil429KPVItXa6xgO7z6GusQBF4wwyN/ZhQ9ctsAcb+F5bDoTB B8SVVufNY5tA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="321091417" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2020 18:30:57 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 18:30:57 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 09:30:54 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 1 Jul 2020 09:30:54 +0800 From: "Di, ChenxuX" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [PATCH v2 1/5] net/i40e: add private APIs Thread-Index: AQHWQr35YVsSAYh3jEWo9rFJmb/qiqjwhcsAgAGCdGA= Date: Wed, 1 Jul 2020 01:30:54 +0000 Message-ID: <350673efbd454a77ad9d59ce7456f268@intel.com> References: <20200611060142.75465-1-chenxux.di@intel.com> <20200615021858.13985-1-chenxux.di@intel.com> <20200615021858.13985-2-chenxux.di@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: add private APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Qiming > Sent: Tuesday, June 30, 2020 6:25 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [PATCH v2 1/5] net/i40e: add private APIs >=20 >=20 >=20 > > -----Original Message----- > > From: Di, ChenxuX > > Sent: Monday, June 15, 2020 10:19 > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Yang, Qiming > > ; Di, ChenxuX > > Subject: [PATCH v2 1/5] net/i40e: add private APIs > > > > The legacy filter API will be superseded by rte_flow. > > There are also several small features which can not be implemented in > > rte_flow. This patch re-implemented these features as private API. > > Three APIs are added: > > rte_pmd_i40e_get_fdir_info. > > rte_pmd_i40e_get_fdir_stats. > > rte_pmd_i40e_set_gre_key_len. > > > > Signed-off-by: Chenxu Di > > --- > > doc/guides/rel_notes/release_20_08.rst | 14 +++++++ > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > drivers/net/i40e/i40e_ethdev.h | 5 +++ > > drivers/net/i40e/i40e_fdir.c | 4 +- > > drivers/net/i40e/rte_pmd_i40e.c | 51 +++++++++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e.h | 49 ++++++++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 3 ++ > > 7 files changed, 125 insertions(+), 3 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_20_08.rst > > b/doc/guides/rel_notes/release_20_08.rst > > index dee4ccbb5..550ad33aa 100644 > > --- a/doc/guides/rel_notes/release_20_08.rst > > +++ b/doc/guides/rel_notes/release_20_08.rst > > @@ -62,6 +62,20 @@ New Features > > > > * Added new PMD devarg ``reclaim_mem_mode``. > > > > +* **Updated the Intel i40e driver.** > > + > > + Updated the Intel i40e driver with new features and improvements, > > including: > > + > > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > > + * Re-implemented set_gre_key_len in private API. > > + * Added support for flow query RSS. > > + > > +* **Updated the Intel ixgbe driver.** > > + > > + Updated the Intel ixgbe driver with new features and improvements, > > including: > > + > > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > > + > > > > Removed Items > > ------------- > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 970a31cb2..674b711d9 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -8787,7 +8787,7 @@ i40e_tunnel_filter_param_check(struct i40e_pf > > *pf, > > > > #define I40E_GL_PRS_FVBM_MSK_ENA 0x80000000 > > #define I40E_GL_PRS_FVBM(_i) (0x00269760 + ((_i) * 4)) > > -static int > > +int > > i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len) { struct > > i40e_pf *pf =3D &((struct i40e_adapter *)hw->back)->pf; diff -- git > > a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h > > index e5d0ce53f..192636927 100644 > > --- a/drivers/net/i40e/i40e_ethdev.h > > +++ b/drivers/net/i40e/i40e_ethdev.h > > @@ -1270,6 +1270,11 @@ enum i40e_filter_pctype uint16_t flow_type); > > uint16_t i40e_pctype_to_flowtype(const struct i40e_adapter *adapter, > > enum i40e_filter_pctype pctype); > > +int i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len); void > > +i40e_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info > > +*fdir); void i40e_fdir_stats_get(struct rte_eth_dev *dev, struct > > +rte_eth_fdir_stats *stat); > > int i40e_fdir_ctrl_func(struct rte_eth_dev *dev, > > enum rte_filter_op filter_op, > > void *arg); >=20 > It doesn't make sense to add the definition here as these functions only = called by > private API. > I think it better to move these function to private also >=20 For the reason the legacy filter API and function is not really removed, it= will call the function. It may not be the right time to move the functions to private. The same as ixgbe. > [...] >=20 >=20 > > -- > > 2.17.1 >=20