From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ADA121B223 for ; Mon, 9 Oct 2017 19:47:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4D74A20F35; Mon, 9 Oct 2017 13:47:05 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 09 Oct 2017 13:47:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=LdSZj9n6md24cHt 3qyqgdlZmCS903WofgvkpXU9F3yU=; b=rlhtMEyglD9PPQCckUwvOhWaW5ZAZP9 t1i0bGUAC0s8TnGUg0AkDkInaGT06dSS0cwvztCQzm87V8nqJi78VFz3FzWMbmrd /bkqVA/s5GMghcA8JmWLK74I9Pq+YeNulb+Jmb5Eh070wZ6FJL3TIfpFhzJRJFjL Omp2V3U6Ny80= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=LdSZj9n6md24cHt3qyqgdlZmCS903WofgvkpXU9F3yU=; b=pDJFLJIL l6vPKlj8HIPKNzZ8nUSdZDrGVSP7ZJQrUCVs6JdVCHYZzfPYtYGwUDGRzxkheOrz bSn8wX/RZDnu1z8N2pGRoA86zUGRGFrAwuusAoSguzSVkTsyIXcbZBNqwaJa17jH S+AjD/CpE9wuGHn/Nwg2fTZihy9KmUwUoCkLZfCnSww7PaDPkGWfG3r2zEKvDSXU 80i9WF1ct5y+/t6BcsQfPRajAc+OlUZKSNgm1ZbQtq9vFE86i7V9jF8Oq9efCO7V yxolJDrDTOOndn01SR3UM72RV4yV2DpOO6KXS31YGsoDZ9gR7W1OYdgMMXW4TSmt aJ9d5zoUxKozsg== X-ME-Sender: X-Sasl-enc: kkAbHgpElqhFwRmt4zyRFJ4nJF40ZfBqLBN5xmRwzVRA 1507571224 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF55F24372; Mon, 9 Oct 2017 13:47:04 -0400 (EDT) From: Thomas Monjalon To: Xiaoyun Li Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com Date: Mon, 09 Oct 2017 19:47:04 +0200 Message-ID: <35071535.8NSjKInSoG@xps> In-Reply-To: <1507206794-79941-2-git-send-email-xiaoyun.li@intel.com> References: <1507157911-8702-1-git-send-email-xiaoyun.li@intel.com> <1507206794-79941-1-git-send-email-xiaoyun.li@intel.com> <1507206794-79941-2-git-send-email-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/3] eal/x86: run-time dispatch over memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 17:47:05 -0000 05/10/2017 14:33, Xiaoyun Li: > +/** > + * Macro for copying unaligned block from one location to another with constant load offset, > + * 47 bytes leftover maximum, > + * locations should not overlap. > + * Requirements: > + * - Store is aligned > + * - Load offset is , which must be immediate value within [1, 15] > + * - For , make sure bit backwards & <16 - offset> bit forwards are available for loading > + * - , , must be variables > + * - __m128i ~ must be pre-defined > + */ > +#define MOVEUNALIGNED_LEFT47_IMM(dst, src, len, Naive question: Is there a real benefit of using a macro compared to a static inline function optimized by a modern compiler? Anyway, if you are doing a new version, please reduce lines length and fix the indent from spaces to tabs. Thank you