From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 55E561B5EB for ; Wed, 18 Oct 2017 08:24:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AF92C20BB9; Wed, 18 Oct 2017 02:24:35 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 18 Oct 2017 02:24:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=jWL1tedBeYsoHKm8+xiYSTmfSH dDCRNKHvmGfvzJdKI=; b=sbTeMSr6OeW+GbTcVG24DjtdsV4qfPcTfb8EkJjh9A Pzb4Hs4GRBHuXIbL84n2lX99IXsstZSsQDt+EPUEA0y2QYai49jyoKrwBoWItdpn R1CZRuEu1nMTKxUZPnHoASUlathJm+eGkCeh4R/5uDI9v5w6pUtOOwk9t6YTIH0w U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jWL1te dBeYsoHKm8+xiYSTmfSHdDCRNKHvmGfvzJdKI=; b=IdhlWMU2jZjIqQbtil0mtF fvd9L5WEE58utz6NW3TNVCDUjwPKhdbgapjgxl6fITb07DIiTUr1ddS4F1LIoe69 55YYaHuqMB1ZfjiWDN/AtLfwq5sc2F2e0Kym6s43IzJnlXHjBLdrV50QeEXnqfui ZdZ3siHVY03mJzF2WlTU4+QHfZx356Fk+SfUnwwwz09AimlBAvpWjyJY4SL8p4dr 9syW+Mex9PyYtImsUmxKKWBRJ6QQPVWwznmFjOcqUhuTO0838DkT8HeROUufUj2R 24ltFkguGsNhmOIY7FH6ltZF4Sl2cInuoyChKgMh/+ysTL5zFMb+GGBK5Va2Ehsg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EE0D7F980; Wed, 18 Oct 2017 02:24:35 -0400 (EDT) From: Thomas Monjalon To: Alexey Kardashevskiy Cc: "Burakov, Anatoly" , dev@dpdk.org Date: Wed, 18 Oct 2017 08:24:34 +0200 Message-ID: <3509725.R4iCQoWzDS@xps> In-Reply-To: <65996a36-e64e-248c-d22b-cd9db1ba5e3f@ozlabs.ru> References: <20170426080908.24026-1-aik@ozlabs.ru> <1734105.V98Xar4r66@xps> <65996a36-e64e-248c-d22b-cd9db1ba5e3f@ozlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 06:24:36 -0000 18/10/2017 07:11, Alexey Kardashevskiy: > On 18/10/17 03:13, Thomas Monjalon wrote: > > 28/04/2017 13:19, Burakov, Anatoly: > >> From: Alexey Kardashevskiy > >>> VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for > >>> just created DMA window. It happens to start from zero because the default > >>> window is removed (leaving no windows) and new window starts from zero. > >>> However this is not guaranteed and a new window may start from another > >>> address, this adds a check and an error message. > >>> > >>> > >>> Signed-off-by: Alexey Kardashevskiy > >>> --- > >>> Changes: > >>> v2: > >>> * this just prints warning and fails instead of incorrectly changing IOVA > >>> addresses > >>> --- > >> > >> Hi Alexey, > >> > >> There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :) > >> > >> I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though. > > > > Please, can we progress on this patch? > > Is it still a relevant patch? > > Nope, http://dpdk.org/browse/dpdk/commit/?id=ed1e7e576be219e1e has the > warning, this is enough really. OK, I've marked it as superseded in patchwork. Thanks