From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhou, Danny" <danny.zhou@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO
Date: Mon, 23 Feb 2015 14:28:08 +0100 [thread overview]
Message-ID: <3509738.2W4po8ncMD@xps13> (raw)
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AAB360B@SHSMSX104.ccr.corp.intel.com>
2015-02-23 11:47, Zhou, Danny:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-02-19 21:48, Zhou Danny:
> > > --- a/lib/librte_eal/linuxapp/eal/Makefile
> > > +++ b/lib/librte_eal/linuxapp/eal/Makefile
> > > @@ -43,6 +43,7 @@ CFLAGS += -I$(SRCDIR)/include
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_ring
> > > +CFLAGS += -I$(RTE_SDK)/lib/librte_mbuf
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_malloc
> > > CFLAGS += -I$(RTE_SDK)/lib/librte_ether
> >
> > Why do we need mbuf in EAL?
>
> The file eal_interrupts.c includes rte_ethdev.h which defines structure rte_eth_devices that
> eal needs to use in order to get per-port intr_handle. The rte_ethdev.h includes the rte_mbuf.h
> so the Makefile is updated here.
I see. You are breaking layer isolation by introducing ethdev in EAL.
The cause seems to be:
+ struct rte_intr_handle intr_handle =
+ rte_eth_devices[port_id].pci_dev->intr_handle;
Maybe that pci_dev should be a parameter of the function.
next prev parent reply other threads:[~2015-02-23 13:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 13:48 [dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add rx interrupt enable/disable functions Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF Zhou Danny
2015-02-23 11:19 ` Thomas Monjalon
2015-02-23 11:23 ` Zhou, Danny
2015-02-23 13:20 ` Thomas Monjalon
2015-02-23 15:11 ` Zhou, Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 3/5] igb: enable rx queue interrupts for PF Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO Zhou Danny
2015-02-20 22:43 ` Thomas Monjalon
2015-02-23 11:47 ` Zhou, Danny
2015-02-23 13:28 ` Thomas Monjalon [this message]
2015-02-23 15:02 ` Zhou, Danny
2015-02-23 15:19 ` Thomas Monjalon
2015-02-23 15:24 ` Zhou, Danny
2015-02-21 2:56 ` Jun Xiao
2015-02-23 11:23 ` Zhou, Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 5/5] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch Zhou Danny
2015-02-20 8:50 ` [dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD Gonzalez Monroy, Sergio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3509738.2W4po8ncMD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danny.zhou@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).