From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id D94BAAD95
 for <dev@dpdk.org>; Mon, 23 Feb 2015 14:28:39 +0100 (CET)
Received: by wevk48 with SMTP id k48so18139715wev.3
 for <dev@dpdk.org>; Mon, 23 Feb 2015 05:28:39 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=a36Klkj6TEEIs9IJsChPrw382X+y6lUN6beH1E12JvE=;
 b=LFITGAHr6FCPjkJIkNtLF0fHzlUGNVTxcbu7+Ji9jmojsZBe4ZHJzE//ibiCZ/9anj
 DLnPIavaxSwn9TMZ9h+/zGXS90U6/qGdpOheygTdVMzYVGgUDcEqmgNXIfESy1O9v0Uj
 LegRMZhs3RxaWDvPD6siKByugNaizpanWjKECpLYrzEZXdC2M2uQ0SwlSTvQ0DS06e/y
 435mT4OTCNwJE4SZwYxIhaCNE8H5akR1MshyhjNvzbVm2FYJ4l5SZ9aXaco3rty1dMwZ
 KuWg5DI4tRN7hmWp2RzylVzZnb837cNQNVxUl6rkVyCDOBm6VTWNU6H6lOqmmCbUE1+U
 ICKA==
X-Gm-Message-State: ALoCoQmhYhQepY4u8jW0TPuS5b+5KaYPzGKcR5n/xRFWGLTMtIL+WVXZ2mtEiln5Cxgcx4NZDwJ8
X-Received: by 10.194.59.209 with SMTP id b17mr21341548wjr.67.1424698119763;
 Mon, 23 Feb 2015 05:28:39 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lu13sm15910541wic.10.2015.02.23.05.28.37
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 05:28:38 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhou, Danny" <danny.zhou@intel.com>
Date: Mon, 23 Feb 2015 14:28:08 +0100
Message-ID: <3509738.2W4po8ncMD@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AAB360B@SHSMSX104.ccr.corp.intel.com>
References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com>
 <6417495.deEVoxQ023@xps13>
 <DFDF335405C17848924A094BC35766CF0AAB360B@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt
	handling based on VFIO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 13:28:40 -0000

2015-02-23 11:47, Zhou, Danny:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-02-19 21:48, Zhou Danny:
> > > --- a/lib/librte_eal/linuxapp/eal/Makefile
> > > +++ b/lib/librte_eal/linuxapp/eal/Makefile
> > > @@ -43,6 +43,7 @@ CFLAGS += -I$(SRCDIR)/include
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_ring
> > > +CFLAGS += -I$(RTE_SDK)/lib/librte_mbuf
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_malloc
> > >  CFLAGS += -I$(RTE_SDK)/lib/librte_ether
> > 
> > Why do we need mbuf in EAL?
> 
> The file eal_interrupts.c includes rte_ethdev.h which defines structure rte_eth_devices that 
> eal needs to use in order to get per-port intr_handle. The rte_ethdev.h includes the rte_mbuf.h
> so the Makefile is updated here.

I see. You are breaking layer isolation by introducing ethdev in EAL.
The cause seems to be:

+       struct rte_intr_handle intr_handle =
+                               rte_eth_devices[port_id].pci_dev->intr_handle;

Maybe that pci_dev should be a parameter of the function.