From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: stable@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,
dev@dpdk.org, tredaelli@redhat.com, ferruh.yigit@intel.com,
ivan.malov@oktetlabs.ru, arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] log: add missing experimental tag
Date: Wed, 19 Dec 2018 02:30:21 +0100 [thread overview]
Message-ID: <35118713.S1eQjJEhqc@xps> (raw)
In-Reply-To: <20181204151853.GB31778@hmswarspite.think-freely.org>
04/12/2018 16:18, Neil Horman:
> On Tue, Dec 04, 2018 at 09:28:31AM +0100, David Marchand wrote:
> > When rte_log_register_type_and_pick_level() has been introduced, it has
> > been correctly added to the EXPERIMENTAL section of the eal map and the
> > symbol itself has been marked at its definition.
> >
> > However, the declaration of this symbol in rte_log.h is missing the
> > __rte_experimental tag.
> > Because of this, a user can try to call this symbol without being aware
> > this is an experimental api (neither compilation nor link warning).
> >
> > Fixes: b22e77c02620 ("eal: register log type and pick level from args")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
+Cc stable@dpdk.org
Applied, thanks
prev parent reply other threads:[~2018-12-19 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 8:28 [dpdk-dev] " David Marchand
2018-12-04 15:18 ` Neil Horman
2018-12-18 10:29 ` David Marchand
2018-12-19 1:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35118713.S1eQjJEhqc@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).