From: Thomas Monjalon <thomas@monjalon.net>
To: Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>,
ferruh.yigit@amd.com, lihuisong@huawei.com,
liudongdong3@huawei.com
Subject: Re: [PATCH v2] examples/ethtool: fix pause configuration
Date: Wed, 22 Nov 2023 23:50:23 +0100 [thread overview]
Message-ID: <3515528.V25eIC5XRa@thomas> (raw)
In-Reply-To: <20231110033039.2111-1-lihuisong@huawei.com>
10/11/2023 04:30, Huisong Li:
> Currently, the pause command in ethtool to enable Rx/Tx pause has the
> following problem. Namely, Assume that the device supports flow control
> auto-negotiation to set pause parameters, which will the device that does
> not support flow control auto-negotiation fails to run this command.
>
> This patch supports the configuration of flow control auto-negotiation
> and fixes the print format and style of the pause cmd to make it more
> readable.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
prev parent reply other threads:[~2023-11-22 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 8:42 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-06-28 2:17 ` Min Hu (Connor)
2021-07-17 2:15 ` Min Hu (Connor)
2021-09-28 1:20 ` Min Hu (Connor)
2023-07-03 23:19 ` Stephen Hemminger
2023-11-10 3:30 ` [PATCH v2] " Huisong Li
2023-11-22 22:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3515528.V25eIC5XRa@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).