From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E1A94339F; Wed, 22 Nov 2023 23:50:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B4D3402C7; Wed, 22 Nov 2023 23:50:30 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id AA3A3402BE for ; Wed, 22 Nov 2023 23:50:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 292093200B1F; Wed, 22 Nov 2023 17:50:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 22 Nov 2023 17:50:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700693426; x=1700779826; bh=CQp6qqqYZvAW7+XiyElT6Sr+wK1mIwG1hDU R/L05cYs=; b=hb+kLiXLIMkXlUBDDrtmEWfBO2kpfx4GPPeZvlkyyomjCJloHCV NCcRZV8jueaiuSmqC9IV+hRT1HOHMtoBehxrAVvHA2G+LG1zOXPy2OdPzo9YXMft Fw89e+d5kiKhzFDIKRGiV3zKX1LloUE9mXrx2ydQDWRuuPPWrCVhpKIXP3LsmQDJ Q5s48d40GdSI1QGydvA23uRYnRGcIpkXef2LRsyIiteYhQRaOfIWQ6h0Ni9qP85Q VI7LyCRE78eJNrRArjJHYwje3dJTf+ragjIvXfNm5EcT8l+qFZuC9iZjgHnsdeDS TVhN/NG8efK4MuGVQiiez+XMeF4BlMKeibQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700693426; x=1700779826; bh=CQp6qqqYZvAW7+XiyElT6Sr+wK1mIwG1hDU R/L05cYs=; b=ybhzfWJ0+4ZjqhqhYdRCafE9a3DpMOss2D4f93PitoWGGIJqLgk R1LvXItwrQW3IW7tODRxeTr6gBcmnHDaKnQVTNNuWh/Ony3wMlmc4e8N2QOREDb8 wB+2u0ehJAAJqxbOTtyWwYWzQMQ+09TxiAREygsuNC+v0LlMI2XY5RVZVv+UEhQd WHE68H0ASasO4FXZX8VNkYCflipBqp2clVLOZtWp5cwNODYs8YIfuB2RtofSVchV vd5qhs7Ka23qosP+ox2RxT0w6lGq3tNlo41F3O3ustXT7VOK8WRtjjd84YA6aMSS WUZSKdcHGGcnz/G/bok3hIFeOGTkFaAxjsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehvddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 17:50:25 -0500 (EST) From: Thomas Monjalon To: Huisong Li Cc: dev@dpdk.org, Remy Horton , ferruh.yigit@amd.com, lihuisong@huawei.com, liudongdong3@huawei.com Subject: Re: [PATCH v2] examples/ethtool: fix pause configuration Date: Wed, 22 Nov 2023 23:50:23 +0100 Message-ID: <3515528.V25eIC5XRa@thomas> In-Reply-To: <20231110033039.2111-1-lihuisong@huawei.com> References: <1619599379-470-1-git-send-email-humin29@huawei.com> <20231110033039.2111-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/11/2023 04:30, Huisong Li: > Currently, the pause command in ethtool to enable Rx/Tx pause has the > following problem. Namely, Assume that the device supports flow control > auto-negotiation to set pause parameters, which will the device that does > not support flow control auto-negotiation fails to run this command. > > This patch supports the configuration of flow control auto-negotiation > and fixes the print format and style of the pause cmd to make it more > readable. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > Acked-by: Stephen Hemminger Applied, thanks.