From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5498BA0543; Tue, 24 May 2022 21:23:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38D00400EF; Tue, 24 May 2022 21:23:12 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id DECE1400D6 for <dev@dpdk.org>; Tue, 24 May 2022 21:23:10 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id AB8FC3200495; Tue, 24 May 2022 15:23:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 24 May 2022 15:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653420188; x= 1653506588; bh=M3rUpNF0hmya7Jarg/2/Nsgbof+X0BmrFg3SKBiytUc=; b=U J9GU2A0fpqfUXYtryxy8SaIlUUR/2mrw5dMnGtvOj5i/1ZejGyyBL2o1njgSlSPU F9le8jgYaz48n+bbnGH5Ezkrp7WCe4xf4kqkjaaGLsWQVYOtQLuaGwcgaIBVqRzx NJCyQtOOW8UpAsdFi/8x8DHyDMPM/QJbLReFCovs3dHOONqNRUzPpoJkn6t/5aPK a3BbkbmHtxNX4cI7RYr0j/7l+9WE9DzKSKT4cUV8CYawHjXh2xkPIAESj3N5mQCn k41+PBYRCnIDIyLMBjpe2x7vHaKxSe+52cyM96C8jrHJBYgCXkEOlYvKGWe6z3N6 K8Yx/A1sV96/BEJTPjeYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653420188; x= 1653506588; bh=M3rUpNF0hmya7Jarg/2/Nsgbof+X0BmrFg3SKBiytUc=; b=d MlHJwjpBDOljENqlPgnH4UdqFBAJCjddOfh7gJcSsKaE715rUCg7BhSEXbkS5nLn GGy4OEbjfWl6REwItPodONv7qKAs0x3UIVc3r9xi7a6SGUisvn0Ej+8F89v7KsQP kyN2dJ3rYEuroygZz17cIqh30NxLNQBjHjcjR5bRfnjx14mblFdKplzq9vb0DUv6 AGA7ro6Q4jSe8EnULwrl9+S7Q7fs1hfdEnnnGG2a+N4ZxZxLLr9STIF/1hqEcvrJ CixpqPqzfwKjWDFbt1ayOGGFZfWD88lry48GJiSoToOOCQsfOVN9gKNwAr1l3Zna hGQQtfMI0t4dAA1EfEOVQ== X-ME-Sender: <xms:mzCNYh1h4jW0if48DJgKAxq9TiZ7_ikzShq8LeNhoKSxHS2m8KDCOQ> <xme:mzCNYoGDVUm2PjPKsQN2qzrhd0jGq5kp1ByFHdQuxohRhqXAlRoV0JeBIEo1gPb0o t_umAbsgK7owA9a3A> X-ME-Received: <xmr:mzCNYh482x3HSsgSTaRCzgMryS8F11InTdnH35eGNlesH_xahbyYjE5phE5pjqhtLDZc9Sl1SIjXdycii-Lv> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeefgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:mzCNYu345mIhvaIAxXhU2LotNbT0bV6mEe6bVmr6huAWUGwpf1VcEw> <xmx:mzCNYkGvvNzWMPTxo7b0w9LWWWtq9b7iTJ0k-Ainabt8kUfPoLBsxA> <xmx:mzCNYv-gnfCzLh_9-HZ4FkYhCc0NWr8X3L-NbyU2MF7myLdTBcBCiA> <xmx:nDCNYvAuELPVQrodHGPTYtAmQWjK4oeRJmjfkCA7A3ZvSpWsCfm-SQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 May 2022 15:23:05 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Spike Du <spiked@nvidia.com>, Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, dev@dpdk.org, rasland@nvidia.com, stephen@networkplumber.org, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, david.marchand@redhat.com Subject: Re: [PATCH v3 0/7] introduce per-queue limit watermark and host shaper Date: Tue, 24 May 2022 21:22:57 +0200 Message-ID: <3519312.WbyNdk4fJJ@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D870AA@smartserver.smartshare.dk> References: <20220522055900.417282-1-spiked@nvidia.com> <6057836.17fYzF0512@thomas> <98CBD80474FA8B44BF855DF32C47DC35D870AA@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 24/05/2022 21:00, Morten Br=F8rup: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 24/05/2022 17:20, Spike Du: > > > LWM(limit watermark) is per RX queue attribute, when RX queue > > fullness reach the LWM limit, HW sends an event to dpdk application. >=20 > Please ignore this comment, it is not important, but I had to get it out = of my system: I assume that the "LWM" name is from the NIC datasheet; other= wise I would probably prefer something with "threshold"... LWM is easily co= nfused with "low water mark", which is the opposite of what the LWM does. N= ames are always open for discussion, so I won't object to it. Yes it is a threshold, and yes it is often called a watermark. I think we can get more ideas and votes about the naming. Please let's conclude on a short name which can be inserted easily in function names.