From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix build issue
Date: Tue, 06 Nov 2018 13:29:19 +0100 [thread overview]
Message-ID: <3520386.84pXejHKmD@xps> (raw)
In-Reply-To: <20181106114435.14770-1-jerin.jacob@caviumnetworks.com>
06/11/2018 12:45, Jerin Jacob:
> Some toolchain has fls() definition in string.h as argument type int,
> which is conflicting uint32_t argument type.
>
> /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19:
> error: conflicting types for ‘fls’
> static inline int fls(uint32_t x)
> ^~~
>
> /opt/marvell-tools-201/aarch64-marvell-elf/include/strings.h:59:6:
> note: previous declaration of ‘fls’ was here
> int fls(int) __pure2;
>
> FreeBSD string.h also has fls() with argument as int type.
> https://www.freebsd.org/cgi/man.cgi?query=fls&sektion=3
>
> Fixing the conflict by renaming internal function as __fls
Why not rte_fls? Would it be more future proof?
next prev parent reply other threads:[~2018-11-06 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 11:45 Jerin Jacob
2018-11-06 12:29 ` Thomas Monjalon [this message]
2018-11-06 13:31 ` Jerin Jacob
2018-11-06 20:27 ` Thomas Monjalon
2018-11-07 6:59 ` [dpdk-dev] [PATCH v2 1/2] eal: introduce rte version of fls Jerin Jacob
2018-11-07 6:59 ` [dpdk-dev] [PATCH v2 2/2] eal: fix build issue Jerin Jacob
2018-11-12 1:37 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-12 4:50 ` Jerin Jacob
2018-11-12 9:01 ` Ferruh Yigit
2018-11-12 9:17 ` Thomas Monjalon
2018-11-12 12:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3520386.84pXejHKmD@xps \
--to=thomas@monjalon.net \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).