From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70F6CA0561; Wed, 17 Mar 2021 18:47:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A5B7140F0B; Wed, 17 Mar 2021 18:47:48 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A78C8140F06 for ; Wed, 17 Mar 2021 18:47:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 42EFA5C00A0; Wed, 17 Mar 2021 13:47:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 17 Mar 2021 13:47:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2sYXoxiILhDnlXNWo5awXbnCwQU53UVX/S9Xx6Kdkck=; b=000ri/nI46fNQFnR CnP8mHlPYapnSJGsynNaEpSUFhN7VGD38Yj7T0+ycz64MFMU6xkgXt12Evv1F/qG Dp9CcWJtv/7Opb0RrjBAZEQHK2KWL1OD/BwOX2lQL+dgwYxl6jhn+Ll8t7jDV6aM 1e/JNVORRgQ3Zs3kK6kun5vDEiCTH1ZhVmxjsYjtRxTcPz8A7WIVPU667XUE24yA rMOEq6YRKfuinOli1ox6RE7mlSMeDW66KZVFQzND1OckphULmNdeYAPMGh7Mjxz1 ZgKQe5VClJAI47UjiFfzBmHgLoJbcasXh2v05SHPh7jUkVNPnB8Lry+0JcI0lksq RgodKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2sYXoxiILhDnlXNWo5awXbnCwQU53UVX/S9Xx6Kdk ck=; b=elrdPYgIb7RBG9LuO+4Aeb0u0Ex9DtlCPO3QGWlsXlvGk6V7wHVm+ryMp PncwwF+v/zQ2EzRazr7snhATll2F/OnPd0Cv8S8LQDA5DZI3JXoFAiTTOUQwCfCM nXxaaTG0bLWsPMOf0QmjYR9iY/i7JFF0OayjNiTstP/Cy9xtQ9y/rHLzooIVr/k5 IPVkj0fpS6kVwBNY71N6in+8nCESOa8Iy28frvegn6E+ncnBiTot9C4TnzqB1TwL cyjgVDC1+KhLox324IKuvdOw1DJEZp1JrWIYl/tUUB/FvlvMfOK+660ZtFjHAoIg dsr/AKcj0A4s6XxyN2oMIGpy9btfg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefgedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeelhfeijeehudeuhfekjeeliedukedufefgveelfedujefgueeh heeikeetheehheenucffohhmrghinhepphhmugdrnhgvthdpughpughkrdhorhhgnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 38DFF1080057; Wed, 17 Mar 2021 13:47:45 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Matan Azrad Cc: dev@dpdk.org, Shahaf Shuler Date: Wed, 17 Mar 2021 18:47:42 +0100 Message-ID: <3521796.ZFAWV6j5Mt@thomas> In-Reply-To: References: <20210308222855.823670-1-thomas@monjalon.net> <20210309094836.988763-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/03/2021 18:29, Ferruh Yigit: > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > The macro DEBUG was doing nothing if not compiled with > > RTE_LIBRTE_MLX4_DEBUG. > > > > As it is not used in the data path, it can be always enabled at > > compilation time. Then it can be enabled at runtime with: > > --log-level pmd.net.mlx4:debug > > > > Signed-off-by: Thomas Monjalon > > +1 to change, but why 'RTE_LIBRTE_MLX4_DEBUG' exists at first place? > > It seems is is used both for data and control path, can you extend the patch for: > 1- Remove #ifdef from control path > 2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for data path, > please see: https://patches.dpdk.org/project/dpdk/list/?series=15738 > 3- Remove 'RTE_LIBRTE_MLX4_DEBUG' completely, if not removed document it in the > driver documentation as supported config file To me using ETHDEV config macro in PMDs is new, and I think it is out of scope for this patch. But yes I agree it would be a nice improvement. Matan, please could you do this change during next month?