From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64DB2A0524; Mon, 19 Apr 2021 16:06:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4E984130F; Mon, 19 Apr 2021 16:06:23 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id BDBC1412E6 for ; Mon, 19 Apr 2021 16:06:22 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 59E255C00A3; Mon, 19 Apr 2021 10:06:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 10:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= lb5fhj1pNGGl5/OB0Rw0iO8gEyqWIAXiYK4/2J96BQQ=; b=XnRUmwporNNVnmT3 B5e4mR/7ePGXu2CBBkaRSb2Z6sB8SkECfaPTkwR7qR6VLcYDIxzq6osnRBpFTdLK BzZYm2mSHZyu580rNp9gRjy4FTcavuqo81PXifNBALQup1/kqckoOczw+xlEHAol 7hUFhDwyxfaGTLszF32CDN3N57hgsW0CVeRrR40bjiosS6rXv/p3mzXacvHs2tKU r7lWgbQiWQ4mcdL0hKCN7UQ9WbvPFio5CQk02ZP3EH0p/yqDDKG897kiwq/pwh6+ E46RYSOHQzhud/9ZKCC5u2y+65uZFmmizwj4+ByZhGdMVERObeeB96lOQVKObQg7 Q++yhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=lb5fhj1pNGGl5/OB0Rw0iO8gEyqWIAXiYK4/2J96B QQ=; b=ieyNaWbTLBh2Xn0LT6L7hhHDunhDL4YpgcdG4A7TSuikI+FCkfsuwJo3E /DwlNXLX0icG+1feHUg8YXwu55N+dHddLxnWghpe4dv32P2s/aWh9EdRigWKvvOO G3xGHr2bE+TIXSzSJNuM51eZQj5OJ8AxpbJ8Nhx5qCb98aco9EtH+G+XHInNS9kT 7rL7obKuhpDGS8rCkCOJWqYOihPneIEP7f0COGQZAaelDGaFyMvtj1OKY7R2YGO1 wM0aXcLQJMJJrNpmQKESnXLdWtwz5ZNrsuxH1Xf//vcER1q/tM+73CsGH9gAjLah X7vr6vHVjkV/ruNjhTTXFhjZ1RDlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9EDF9108006A; Mon, 19 Apr 2021 10:06:20 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: orika@nvidia.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, ajit.khaparde@broadcom.com, xiaoyun.li@intel.com Date: Mon, 19 Apr 2021 16:06:19 +0200 Message-ID: <3521936.dDA8s7yrex@thomas> In-Reply-To: <1618595649-157464-2-git-send-email-bingz@nvidia.com> References: <1618062393-205611-1-git-send-email-bingz@nvidia.com> <1618595649-157464-1-git-send-email-bingz@nvidia.com> <1618595649-157464-2-git-send-email-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/04/2021 19:54, Bing Zhao: > +/** > + * The packet is valid after conntrack checking. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_VALID RTE_BIT32(0) > +/** > + * The state of the connection is changed. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_CHANGED RTE_BIT32(1) > +/** > + * Error is detected on this packet for this connection and > + * an invalid state is set. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_INVALID RTE_BIT32(2) > +/** > + * The HW connection tracking module is disabled. > + * It can be due to application command or an invalid state. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_DISABLED RTE_BIT32(3) > +/** > + * The packet contains some bad field(s) and cannot continue > + * with the conntrack module checking. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_BAD RTE_BIT32(4) I like it better now that all bits have the same prefix, thanks. > +enum rte_flow_conntrack_state { > + /**< SYN-ACK packet was seen. */ > + RTE_FLOW_CONNTRACK_STATE_SYN_RECV, > + /**< 3-way handshake was done. */ > + RTE_FLOW_CONNTRACK_STATE_ESTABLISHED, > + /**< First FIN packet was received to close the connection. */ > + RTE_FLOW_CONNTRACK_STATE_FIN_WAIT, > + /**< First FIN was ACKed. */ > + RTE_FLOW_CONNTRACK_STATE_CLOSE_WAIT, > + /**< Second FIN was received, waiting for the last ACK. */ > + RTE_FLOW_CONNTRACK_STATE_LAST_ACK, > + /**< Second FIN was ACKed, connection was closed. */ > + RTE_FLOW_CONNTRACK_STATE_TIME_WAIT, > +}; These doxygen comments should not have "<" in them, because they are "before". [...] > + /** No TCP check will be done except the state change. */ > + uint32_t liberal_mode:1; > + /** + enum rte_flow_conntrack_state state; Looks good overrall, thanks.