From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0410BA0567; Sun, 26 Jun 2022 23:12:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8206D41141; Sun, 26 Jun 2022 23:12:28 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id DCB8640E50 for ; Sun, 26 Jun 2022 23:12:26 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id A89AD58012F; Sun, 26 Jun 2022 17:12:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 26 Jun 2022 17:12:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656277942; x= 1656285142; bh=6S/SXOuarw3Zmt12xBYlUlGLptFtDj0/57UtJ0zY6bI=; b=k il29D0xiBdTFqu42ZapOZMbX9uLRK4JW75iEAAZWNtnPtjIlTpcPqkmUH9JI65jf Hk+UsjtZtBJFxzfdg33N+mfzgbGextZoqNEh8JHGsypJ8gW752uQ/+Rsei6+DGb1 eTWgva1rqabz6qv88nJcALEi4DnKKlLHsY7Y2SxlEEchQympXLxTlEku8Qxu04KY fnYOAr3CzPMsAu9/Oo+cfhZ+DWf0utZ1uwpFDWrludoRtoX/0KZ2WOTf2ec0hMQA MTdAF3hNBHc+b8kcEbyn3HMKZfPBlUrPF1BykVhGkyX2N3JII4hIqGN+Do3L5sum VpdsvvsL3r3MivSGwBvKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656277942; x= 1656285142; bh=6S/SXOuarw3Zmt12xBYlUlGLptFtDj0/57UtJ0zY6bI=; b=P Ep9b/Fq7VQziPmMH2L2lXgwwu2g4LGhmP/guFjNkkr6AqQrKKYN82xheMHnRT98V ySpEIycUzU9uycZ9g3Nqlm6qThUhj7sEHNggj0NUigDEV6wEWzWx3Mgqd2h8Rndg MrE5QRrH7pmGDB9CXk/R9h2Xbcu7CZvvIzBlSVIXvG0/zFvB+8jGwNv3peU2ofW5 EtYaqQfOUDFyXUxvhOoKoKBTtvgk84fS7URRKRGqfd3QxQSJKZfAaCkp6Sh7wXSD J8dCrTBHpl7bvzi/aUanEp0flOEsbocBkVYtKeunwMxPNskOLFmiGceYsnAB15L7 QnD+v3x+PtQkp5Oc/dnww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 17:12:13 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Bruce Richardson , ferruh.yigit@xilinx.com, ajit.khaparde@broadcom.com, aboyer@pensando.io, andrew.rybchenko@oktetlabs.ru, beilei.xing@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com, Rahul Bhansali Subject: Re: [PATCH] examples/l2fwd: add check of Rx packets count Date: Sun, 26 Jun 2022 23:12:11 +0200 Message-ID: <3527350.8uLHfb51uz@thomas> In-Reply-To: <20220525091327.4006824-1-rbhansali@marvell.com> References: <20220525091327.4006824-1-rbhansali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please could we have some tests on other hardware with this improvement? 25/05/2022 11:13, Rahul Bhansali: > An additional check is added to avoid extra processing if > receive packets are 0. > > Performance impact: with Marvell OCTEON TX2 platform, observed an > improvement by ~14%. > > Signed-off-by: Rahul Bhansali > --- > nb_rx = rte_eth_rx_burst(portid, 0, > pkts_burst, MAX_PKT_BURST); > > + if (unlikely(nb_rx == 0)) > + continue; > +