From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 1EA40A6A for ; Wed, 4 Mar 2015 17:15:38 +0100 (CET) Received: by wesu56 with SMTP id u56so47387568wes.10 for ; Wed, 04 Mar 2015 08:15:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=UPhvJ4LrzTbdJA3s5WUywL3R/xaeXTb8rAulmXUJ1Xw=; b=br/2vwbOEaN1Tup502Y7qp49cl1weM2LaEDQrpAdPFa6K3Ix7L/JlwPlx9GPSfrLkA pCxFgO3b9FSsX/frHczlua9nROekBkbVuxF7xQJ627mALLCPQiT0DH/p0V/cVx16LExX 5nj3ekNhaqykyPhBXp1Zkkugcev8D9XJlG7y0q8eq+mKHeILuXcsBEelZHs55FFxd/ox N8DISRQ9hLZYx5qcHirTdQ4CCd8b/IQ2QCA0dA4ls58jsbqC0uue6JztsFDOgfCKs+FW oWyHv9Lu/GsOF45N4cJCxZvvvlPXVG99SrhbHgqIrGjbk20vOZwB7ZbUJnbocBw1ws0u Uz/w== X-Gm-Message-State: ALoCoQmQ9/5NFjcLLq7hr+uvW4FcdD60yGvMQ+Pme72ng2WNa1hwVyewhcqaOZs4xqlmsu8qCu9n X-Received: by 10.180.80.34 with SMTP id o2mr57009389wix.75.1425485737856; Wed, 04 Mar 2015 08:15:37 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dm6sm7712974wib.22.2015.03.04.08.15.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 08:15:36 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Wed, 04 Mar 2015 17:15:02 +0100 Message-ID: <3528929.TcjVc3oMj4@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150304154213.GB6187@neilslaptop.think-freely.org> References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <9723665.VmRFLHRQpO@xps13> <20150304154213.GB6187@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 16:15:38 -0000 2015-03-04 10:42, Neil Horman: > On Wed, Mar 04, 2015 at 04:15:18PM +0100, Thomas Monjalon wrote: > > 2015-03-04 09:39, Neil Horman: > > > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > > > > Hi Neil, > > > > > > > > I remove parts that I agree and reply to those which deserve more discussion. > > > > > > > > 2015-03-04 06:49, Neil Horman: > > > > > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote: > > > > > > 2015-02-02 13:18, Neil Horman: > > > > > > > +# Make sure we configure SHARED libraries > > > > > > > +# Also turn off IGB and KNI as those require kernel headers to build > > > > > > > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > > > > > > > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > > > > > > > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET > > > > > > > > > > > > Why not tuning configuration after make config in .config file? > > > > > > > > > > > Because this way we save a reconfig (from a developer viewpoint), you should run > > > > > make config again after changing configs, and so this way you save doing that. > > > > > > > > No, you run make config once and update .config file. That's the recommended > > > > way to configure DPDK. > > > > defconfig files are default configurations and should stay read-only. > > > > > > They get overwritten when we do the git resets. Its silly to modify your config > > > file after you run make config, in the event the make target has to re-read any > > > modified options and adjust dependent config files accordingly. I understand > > > that doesn't happen now, but its common practice for every open source project > > > in existance. > > > > I'm not sure to understand. Maybe an example would help. > > By the way, your method works. > > For example, the linux kernel. The .config file that is generated in the root > directory is converted to an autoconf.h in parallel with its generation, for > applications to key off of. If you change something in .config, you need to run > make config again so that those changes are reflected into the other > auto-generated files. Thats common practice. So its counter intuitive to > assume that altering the generated .config file is automatically recognized by > the rest of the build, without a subsequent make config (be it explicit or and > implicit dependency of the make all target). OK thanks, now I better understand how you think about DPDK config. Note that in Linux you are modifying .config, not the defconfig. I'm not going to debate how it could be improved now but I think we shouldn't dynamically modify defconfig files to avoid confusion about their purpose.