Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 02-Apr-21 10:26 AM, Anatoly Burakov wrote:
> Previous fix for base frequency handling in pstate mode introduced a
> couple of issues:
> 
> - When base_frequency file does not exist, it simply bails out because
>    of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is
>    incorrect, as absence of this file is not fatal and is in fact
>    expected on kernel versions earlier than 5.3
> - When base_frequency file does exist, it gets opened, but never gets
>    closed, resulting in a resource leak
> 
> Both issues also manifest themselves as Coverity defects (dead code, and
> a resource leak), so this fix addresses both.
> 
> Fixes: 4db9587bbf72 ("power: check sysfs base frequency")
> Cc: david.hunt@intel.com
> 
> Coverity issue: 369693
> Coverity issue: 369694
> Bugzilla ID: 668
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---

For some reason git notes got lost on format-patch.

v3:
- Split refactor from bugfixes
v4:
- v3 was erroneously "fixing" handling of base max rather than base 
frequency

-- 
Thanks,
Anatoly