From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 54B2C532C for ; Fri, 12 Apr 2019 10:37:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94C4321EA0; Fri, 12 Apr 2019 04:37:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Apr 2019 04:37:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=et0qX1TTpTJ8fn+26L1l2O1X7yt+RX7EQizmx40nVxM=; b=qq4Prj1MRexF e3xeAztYHZ1vw7ImeYUYrYUSY9ZoVLxmLgZkoHpTryNM/O4Boz3QwMJ4nJLIFjHx O2orrGCZAzDTHruKfRMuZG2LEb4JcoM0XkyzHi7itjWxC64LyzAGtmmil8Ayy3/q koZlChUF7zggKlhiaHHHv/tYwbDeK8I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=et0qX1TTpTJ8fn+26L1l2O1X7yt+RX7EQizmx40nV xM=; b=ivJHniBckDVlv7lwodgy1IGeZzZagkPpRrlcDXiCcZmns3OR5zLbOqDk6 nLSe43JqR2dDIuk0gpAPV/NSAvNmTAsWLkSnDo8GavYx7wAgBNk1trREC2XwwU+c Kn6i7FXUd8iWP+3bK3fHY6NB5itLRAoXE8sKLBtaCTQZ8aVzI4L2jX5h1UunGlZT oL93libpwDPoYLWt5U2Nga8WDVai41vIcdT7A+pftaeJEvQIlBYmsTMhABq0nmCJ R+gwD/jh5CzFpgNDKoWRIc0AH3e54bxab5C7kopvadXMOKIbnpPDsKNS3FF8V62O K0rM0Z9z65hZoJCPWt13KCV24Ytaw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvddtgddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 654D5103A5; Fri, 12 Apr 2019 04:37:56 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" Date: Fri, 12 Apr 2019 10:37:54 +0200 Message-ID: <35352278.91huJt38ux@xps> In-Reply-To: <1555075598-4988-4-git-send-email-g.singh@nxp.com> References: <1554745507-15089-1-git-send-email-g.singh@nxp.com> <1555075598-4988-1-git-send-email-g.singh@nxp.com> <1555075598-4988-4-git-send-email-g.singh@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 03/13] net/enetc: use correct buffer allocation API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 08:37:58 -0000 12/04/2019 09:04, Gagandeep Singh: > rte_pktmbuf_alloc API should be used to allocate mbuf > instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf > information. > > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > Cc: g.singh@nxp.com You should mention it is also fixing big endian compilation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5657DA0096 for ; Fri, 12 Apr 2019 10:38:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A436548B; Fri, 12 Apr 2019 10:38:00 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 54B2C532C for ; Fri, 12 Apr 2019 10:37:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94C4321EA0; Fri, 12 Apr 2019 04:37:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Apr 2019 04:37:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=et0qX1TTpTJ8fn+26L1l2O1X7yt+RX7EQizmx40nVxM=; b=qq4Prj1MRexF e3xeAztYHZ1vw7ImeYUYrYUSY9ZoVLxmLgZkoHpTryNM/O4Boz3QwMJ4nJLIFjHx O2orrGCZAzDTHruKfRMuZG2LEb4JcoM0XkyzHi7itjWxC64LyzAGtmmil8Ayy3/q koZlChUF7zggKlhiaHHHv/tYwbDeK8I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=et0qX1TTpTJ8fn+26L1l2O1X7yt+RX7EQizmx40nV xM=; b=ivJHniBckDVlv7lwodgy1IGeZzZagkPpRrlcDXiCcZmns3OR5zLbOqDk6 nLSe43JqR2dDIuk0gpAPV/NSAvNmTAsWLkSnDo8GavYx7wAgBNk1trREC2XwwU+c Kn6i7FXUd8iWP+3bK3fHY6NB5itLRAoXE8sKLBtaCTQZ8aVzI4L2jX5h1UunGlZT oL93libpwDPoYLWt5U2Nga8WDVai41vIcdT7A+pftaeJEvQIlBYmsTMhABq0nmCJ R+gwD/jh5CzFpgNDKoWRIc0AH3e54bxab5C7kopvadXMOKIbnpPDsKNS3FF8V62O K0rM0Z9z65hZoJCPWt13KCV24Ytaw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvddtgddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 654D5103A5; Fri, 12 Apr 2019 04:37:56 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" Date: Fri, 12 Apr 2019 10:37:54 +0200 Message-ID: <35352278.91huJt38ux@xps> In-Reply-To: <1555075598-4988-4-git-send-email-g.singh@nxp.com> References: <1554745507-15089-1-git-send-email-g.singh@nxp.com> <1555075598-4988-1-git-send-email-g.singh@nxp.com> <1555075598-4988-4-git-send-email-g.singh@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 03/13] net/enetc: use correct buffer allocation API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412083754.3tFnrJZzZPHYTqLIsQbyCvbci5BmluN5fT5RYtKjBiw@z> 12/04/2019 09:04, Gagandeep Singh: > rte_pktmbuf_alloc API should be used to allocate mbuf > instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf > information. > > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > Cc: g.singh@nxp.com You should mention it is also fixing big endian compilation.