From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 5908F4F9A for ; Wed, 13 Mar 2019 12:23:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 48D332038; Wed, 13 Mar 2019 07:23:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Mar 2019 07:23:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Uf8Z4oeI1VhVtN2Bi9JAGRW2xv73+2P7EXa4jHu6s0Q=; b=AlurCp8RdQBS FaxVgXYCiWAdRSOqUGj5R3XPaxOhVOwg2Rh+ERqiFejsrERQ5JWan8re5qks2tlG 4WeKdWOJbrShlEZmO9NeKoqZhchL1I8VmNylponH+FkQaWGGW1u7B8M4bEQozXiA P31lQSN4Opg8EddRfbvOg9OD7j33nqw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Uf8Z4oeI1VhVtN2Bi9JAGRW2xv73+2P7EXa4jHu6s 0Q=; b=UfOHYawfk8KIvfsxLwM7xNOjLOYRBoJ96GHEOPVxK8b46jACl+l3Y2Gby moS1BSNwLmBAP3UcMEm6S/o2CgHEzAMSpBrhNrfH9mymUEZuy4kpzBSiyG/pMA1V cDrqU/E5oGhGUOi5V5hiFMq4D/wW6VyTOukPIy7HaTxA4oLvm9MqLy1QSVLpyQv3 bTcsAqmOliVrCBd3Z+0UlSYycIzBxByB6PKUch/Q+GI8MrjE8JiRPWZ0pp+q7yWc IeuwAvhjSISQAZzZwFE0e1kOSzG4KkvmepjB4M3N4W7GpqwGenV1DLSC7aB7l9z7 xFqW9yIC9w9cTn45hpFHT1L9QcVdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrhedtgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepshgukhgtohhnfhhighdrmhhknecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A59810310; Wed, 13 Mar 2019 07:23:17 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , Luca Boccassi Date: Wed, 13 Mar 2019 12:23:16 +0100 Message-ID: <3536683.yvjcJTvx62@xps> In-Reply-To: <20190313111759.GC1118972@bricha3-MOBL.ger.corp.intel.com> References: <20190307115448.54041-1-bruce.richardson@intel.com> <6766221.dD9Uvtf5Qj@xps> <20190313111759.GC1118972@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:23:20 -0000 13/03/2019 12:17, Bruce Richardson: > On Wed, Mar 13, 2019 at 12:06:38PM +0100, Thomas Monjalon wrote: > > 07/03/2019 14:34, Bruce Richardson: > > > Add a new file DPDK_VERSION to hold the current DPDK version number. > > > Have meson use this file for it's project version, and have make use > > > it for reporting out "showversion" and "showversionum". > > > > > > Signed-off-by: Bruce Richardson > > > Acked-by: Luca Boccassi > > [...] > > > --- /dev/null > > > +++ b/DPDK_VERSION > > > > Why not VERSION ? > > > > No particular reason. I just picked a name I thought reasonable, but I'm > fine with just VERSION on its own. > > The one advantage of having DPDK in the title is that if one has a clone to > a directory called e.g. "temp", a quick "ls" will show the forgetful what > product it was that they cloned to a directory with such an unhelpful name. Good try of justification :) I think I prefer just VERSION. > > [...] > > > --- a/mk/rte.sdkconfig.mk > > > +++ b/mk/rte.sdkconfig.mk > > > showversion: > > > - @set -- \ > > > - $$(sed -rne 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \ > > > - -e 's,^#define RTE_VER_SUFFIX[[:space:]]+"(.*)",\1,p' \ > > > - $(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h) ;\ > > > - printf '%d.%02d.%d' "$$1" "$$2" "$$3"; \ > > > - if [ -z "$$5" ]; then echo; \ > > > - else printf '%s' "$$4"; \ > > > - if [ $$5 -lt 16 ] ; then echo $$5; \ > > > - else echo $$(($$5 - 16)); fi; \ > > > - fi > > > + @cat $(RTE_SRCDIR)/DPDK_VERSION > > > > I'm a bit sad about removing this complex command ;) > > > Yes, but don't worry, I'm proposing a bit of an addition of sed and awk > to other makefile commands to compensate, though sadly not quite as > unintelligable to the masses as this. :-) I can teach you :)