From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0FD74378B for ; Mon, 11 Mar 2019 19:38:36 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F8A7C049E24; Mon, 11 Mar 2019 18:38:35 +0000 (UTC) Received: from [10.36.116.239] (ovpn-116-239.ams2.redhat.com [10.36.116.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CEC85C882; Mon, 11 Mar 2019 18:38:34 +0000 (UTC) To: Ferruh Yigit , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Yan, Zhirun" References: <20190305163039.16790-1-ktraynor@redhat.com> <20190305163039.16790-2-ktraynor@redhat.com> <039ED4275CED7440929022BC67E706115334A38D@SHSMSX103.ccr.corp.intel.com> From: Kevin Traynor Message-ID: <3536cc53-0a13-f5db-1238-a84c9b70f413@redhat.com> Date: Mon, 11 Mar 2019 18:38:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 11 Mar 2019 18:38:35 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 18:38:36 -0000 On 11/03/2019 12:35, Ferruh Yigit wrote: > On 3/11/2019 2:18 AM, Zhang, Qi Z wrote: >> >> >>> -----Original Message----- >>> From: Kevin Traynor [mailto:ktraynor@redhat.com] >>> Sent: Wednesday, March 6, 2019 12:31 AM >>> To: Zhang, Qi Z >>> Cc: dev@dpdk.org; Kevin Traynor ; Yan, Zhirun >>> >>> Subject: [RFC 2/2] net/i40e: update requested queue pair num check for >>> rounding >>> >>> Since rounding up the requested queue pairs to allow the vf to request a >>> non-aligned number was added, it may happen that the requested number is >>> less than the available num of queues but the rounded up number is greater. In >>> this case, it is not caught with the usual checks but later when there is a reset and >>> failed setup. >>> >>> By rounding earlier the checks can be done before a failed reset occurs, and a >>> rounded max amount of available queues can be returned to the vf. >>> >>> Cc: zhirun.yan@intel.com >>> Signed-off-by: Kevin Traynor >> >> Acked-by: Qi Zhang >> >> Applied to dpdk-next-net-intel. >> > > These were checkpatch warnings because of whitespace (spaces before tabs), fixed > while merging to next-net. > Thanks Ferruh. Not spaces before tabs, but using spaces for alignment where there was room for an additional tab. I misinterpreted "spaces for alignment" in the CS note. Maybe it's clear for others, but I'll send a small clarification so I'll remember next time :-)