From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1CF3C5B30 for ; Wed, 7 Mar 2018 16:04:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7D88520A90; Wed, 7 Mar 2018 10:04:46 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 07 Mar 2018 10:04:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+O+b4qYThHNgEGvHeGl5ETTM4b i8t73kTDMFUUNvGLA=; b=l4xgaIUaHpEP7lqZwB6duPZGMs365uCm1kQvxuXgtU tR7FuWZyocaqUFEl3HBJMsfoR3+q/caKkVGalZMQOCg47r3vpbQjDoG88xQ1vbDv JRZFfRZ64Mk3f8Dt6fvcFG2ZRRDzl/9s0J28xtfXyW5NbJNuK4kONGHPCicweSUN Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+O+b4q YThHNgEGvHeGl5ETTM4bi8t73kTDMFUUNvGLA=; b=Dh88ywoju1lI4sPhoVhJcK Kz+7bXUgsjkOCHPUEVUY5WODhAdPv9kvaYX1d+TH9tkMlOTtVpwcvfQVP6iZwBqP 0Opa/OnAV1Nuq8qhQZ3xdm84Y9UTpSqg/Rt2Z3tSa9OAmVnPfdhwqNOoqwtgRidI OA3E0vSQUY9ou8gShQRu4ZKNadQmtuhNpE2wc/sYd0oOS5A7JyD/6c46EykFYAUY ioKfUTeeklg/UgyTVYftNHIQ/W4+ErDS4vzB+ZghZqK/M5u1rNZH0GNrQeuL6+rU xS7GVbl/SinENJauXVb1SJKRMbThL03m0N1xaUJHsxvvYKxoRzpRI9pNrplZe06w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B7C987E41F; Wed, 7 Mar 2018 10:04:45 -0500 (EST) From: Thomas Monjalon To: Arnon Warshavsky Cc: "Burakov, Anatoly" , Bruce Richardson , dev@dpdk.org Date: Wed, 07 Mar 2018 16:04:44 +0100 Message-ID: <35390785.Gg18XPo1UR@xps> In-Reply-To: References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> <4197355.YAsZy1EAlL@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 15:04:47 -0000 07/03/2018 12:02, Arnon Warshavsky: > > > Can this really go into current release without deprecation notices? > > > > If such an exception is done, it must be approved by the technical board. > > We need to check few criterias: > > - which functions need to be changed > > - how the application is impacted > > - what is the urgency > > > > If a panic is removed and the application is not already checking some > > error code, the execution will continue without considering the error. > > > > > Some rte_panic could be probably removed without any impact on > > applications. > > Some rte_panic could wait for 18.08 with a notice in 18.05. > > If some rte_panic cannot wait, it must be discussed specifically. > > > > Every panic removal must be handled all the way up in all call paths. > If not all instances can be removed at once in 18.05 (which seems to be the > case) > maybe we should keep the callback patch until all the remains are gone. Why introducing a new API for a temporary solution? It has always been like that, so the remaining occurences could wait one more release, isn't it?