From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id DE4B77ED7 for ; Mon, 18 Jun 2018 00:37:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4A3B82125E; Sun, 17 Jun 2018 18:37:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 17 Jun 2018 18:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ViTbkfc+xN2AmxTSO+eAg8+qux TlxE9fbIUWETo5oCU=; b=Wisjf6zVePkT1GXFnFNzgc4tfTWivBuzwLTg9DpGKO zZKOzQeqlTabAlGEAX0TtWZ/Fr/f+pFBTF+pU6eDVYFh4jJt0N5Ct4j1IDsdL1Kc TI6yitC/aNxavE9TIyOpoBNP7nNFp+ahMeT1ybs9dYm5dgh41KjelPYO7sZpppY9 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ViTbkf c+xN2AmxTSO+eAg8+quxTlxE9fbIUWETo5oCU=; b=G6hKWw2kWNjDmoD/qqkQE9 cIihp9trJ94LhccYTCG5x+kWQg3EL3m09l/6Ew5ZDLhPo5FYScDGZh/aoSRbMGgD aTrCr/ae4SP4mK48KDy560e1Nc8Yv+XnnW9x8SXalVOscmzDd7jGwniL+HBZ5bR6 bqwzc2497sAshaatCx6l9rkcF3sKqi4+IZVlRQ+5PSvZCofzyk8vyXkBR7zMPJRd pYxIpc6g80zsmAPUr6pBaylnXaAP5Z/ErKKkj6xSsqvGKMxkb4L0e/hxFfsdeLDW 8d1T6DKA6VATU1qR7eKjNNMOCOWuuQJztWMUMkLm/YRVD9CqcrZQw16CXrLz6dfg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4649210266; Sun, 17 Jun 2018 18:37:10 -0400 (EDT) From: Thomas Monjalon To: Michal Krawczyk Cc: dev@dpdk.org, Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , matua@amazon.com Date: Mon, 18 Jun 2018 00:37:08 +0200 Message-ID: <3540745.n2F2IE3GfD@xps> In-Reply-To: <20180607094322.14312-10-mk@semihalf.com> References: <20180607094322.14312-1-mk@semihalf.com> <20180607094322.14312-10-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 22:37:12 -0000 07/06/2018 11:43, Michal Krawczyk: > ENA PMD is required to use librte_timer. The appropriate depndency must > be added ifin case the DPDK will be built as shared library. > > Signed-off-by: Michal Krawczyk > --- > drivers/net/ena/Makefile | 1 + > mk/rte.app.mk | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile > index 43339f3b9..ff9ce315b 100644 > --- a/drivers/net/ena/Makefile > +++ b/drivers/net/ena/Makefile > @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) > LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs > LDLIBS += -lrte_bus_pci > +LDLIBS += -lrte_timer > > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1e32c83e7..c70bc254e 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -60,6 +60,7 @@ endif > > _LDLIBS-y += --whole-archive > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer Why is it added in rte.app.mk? It is already there, few lines below.