From: Thomas Monjalon <thomas@monjalon.net>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru,
dev@dpdk.org, david.marchand@redhat.com,
jerin.jacob@caviumnetworks.com, stable@dpdk.org,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@microsoft.com>
Subject: Re: [PATCH v2] eal/x86: add AMD vendor check to choose TSC calibration
Date: Tue, 13 Feb 2024 16:14:27 +0100 [thread overview]
Message-ID: <3542447.usQuhbGJ8B@thomas> (raw)
In-Reply-To: <fa8aed9c-5556-4ea1-8f85-d63092d6f8f7@amd.com>
23/11/2023 11:29, Ferruh Yigit:
> On 11/23/2023 7:27 AM, Sivaprasad Tummala wrote:
> > AMD Epyc processors doesn't support get_tsc_freq_arch().
> > The patch allows graceful return to allow fallback to
> > alternate TSC calibration.
> >
> > Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC frequency query")
> > Cc: jerin.jacob@caviumnetworks.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied
I don't want to block longer this fix,
but I am not satisfied with the implementation.
David, Ferruh, Bruce and Morten were proposing some abstractions
for CPU features identification.
I think we should start a new enum in rte_cpuflags.h defining some
common CPU features, example is timer calibration here.
The function get_tsc_freq_arch() was already doing some __cpuid calls,
so it's one more, but please could you work on abstracting it in EAL?
Thank you
prev parent reply other threads:[~2024-02-13 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 5:28 [PATCH] eal/x86: add vendor ID checks for specific implementation Sivaprasad Tummala
2023-11-22 11:25 ` Ferruh Yigit
2023-11-22 17:45 ` Tummala, Sivaprasad
2023-11-23 7:27 ` [PATCH v2] eal/x86: add AMD vendor check to choose TSC calibration Sivaprasad Tummala
2023-11-23 10:29 ` Ferruh Yigit
2024-02-13 15:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3542447.usQuhbGJ8B@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=roretzla@microsoft.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).