From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 85276A00C5;
	Thu, 14 Jul 2022 12:07:46 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1DA1C42B73;
	Thu, 14 Jul 2022 12:07:46 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 140FE42B6D
 for <dev@dpdk.org>; Thu, 14 Jul 2022 12:07:45 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 1C8D95C0143;
 Thu, 14 Jul 2022 06:07:42 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Thu, 14 Jul 2022 06:07:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; t=1657793262; x=
 1657879662; bh=GfZlXms0w4Er6/dwjSFaNLb4jJ7u8sfDzGN/aavMAPo=; b=X
 P/SviJdeUEaeG5yW3p1ywwWYmd3Xj/Q0HbvFu3SzrO1gXpIxLgpd/DggNgh73bE7
 zIWs/ZMjAzKjiRblRVH5lavzYAwuOJu0Q3FMhAhDwMzxVuKTXzEGJXlHPX85WCOA
 ZrXCVjBN9vJfuj0iFZJ7/GJdI3UQPQDgPEaCdTrFF3PyoHylczljmXeBHqShgIVl
 P9Qw0C/oz27TBfmzIsSvUYW7kKAbFjmh3rXct7hNyLqi3ENe7qYizyxD9XFI7rir
 MIkiQpIfk85GUvc0Lj/SMvuUgo8VEW0b3eOhgla/5p87yWN4F0ygDNy+og/ewKr7
 e2D7MG1t9HMduU8dA3NPg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657793262; x=
 1657879662; bh=GfZlXms0w4Er6/dwjSFaNLb4jJ7u8sfDzGN/aavMAPo=; b=U
 uiYe+XrHhfvbP4FC0jx7I6mrttjivVHhD0skz7/hbZsKPQXpATcQxAXYCNR6w9x9
 vLcT89MZufWgg2AtvLW0wYFRE7iF+WX77nddQmEV2N40ppfm7tgdJolU/eO+q39+
 kulC4AhGfSRwwA6O2cZfDM5VP9N8dJcc38OgVtyN5jW1yMMPZNRhsJGxtvFJ4M5b
 xKaI5jDCieYlVRU+sgyW/q3S3+Ed8W9kXFcD9K/d3ajMrWmvqSh15ZMuJeeZGorq
 CcnK0GnzGUginv0MRUSlFvIrCcbSAh7+vfV0LC1WV/iwz4Qe0wflVnhoNzarf6nU
 g8hESjQ2YihVBsue4VwBQ==
X-ME-Sender: <xms:7erPYgOMNevZRnbu2sGgVaP2L24rC-3KnqkWbUEi-ubjZpg5GbHPbQ>
 <xme:7erPYm9rUTYyuNbOX60z2yMsTjPFNFLe5KlWGxckoweRUJCJKVBI67VibyPHtqbpv
 an7pMlEqrxSeUPwGw>
X-ME-Received: <xmr:7erPYnTQ5IrjbJz6vTo0TVBciVyQLIAZ6j1rVxNVFJnrSif8zoTCc4Jjlk7WQJ80nx31PG87326sx9345cf5b6gKPA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledgvdefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet
 heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih
 iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvth
X-ME-Proxy: <xmx:7erPYotliL5y9-RkGIenlCgtIkqoIZY9eAFbNg_NgEUF1HP8nygQVw>
 <xmx:7erPYofitQ2pb7dCf4NyEP9UGZtD89kYeEbqVaKafkcsbsqGRvoOWg>
 <xmx:7erPYs1ZUacsRSomjGQiGmDK2y4WsWNTVS3uMvVkUIpR3Ec2QpQzcw>
 <xmx:7urPYvy9-DmUMTP242SJzqNlITXR2hPAQpNXjeBSUKLxFW5aCbrLnA>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 14 Jul 2022 06:07:39 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,
 maxime.coquelin@redhat.com, chenbo.xia@intel.com, mdr@ashroe.eu,
 ferruh.yigit@xilinx.com, olivier.matz@6wind.com, jerinj@marvell.com
Subject: Re: [PATCH v4] doc: announce KNI deprecation
Date: Thu, 14 Jul 2022 12:07:38 +0200
Message-ID: <3550431.7vquxRWeci@thomas>
In-Reply-To: <Ys/f5qPtzs5QJAWP@bricha3-MOBL.ger.corp.intel.com>
References: <20211124171609.3101896-2-ferruh.yigit@intel.com>
 <20220713161047.121805-1-thomas@monjalon.net>
 <Ys/f5qPtzs5QJAWP@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

14/07/2022 11:20, Bruce Richardson:
> On Wed, Jul 13, 2022 at 06:10:47PM +0200, Thomas Monjalon wrote:
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Announce the deprecation plan for KNI kernel module, library and example.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > Squashed and updated 2 deprecations:
> > https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/
> > https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/
> > ---
> 
> One suggestion below.
> With corrected link and with/without suggested change:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> >  doc/guides/prog_guide/kernel_nic_interface.rst | 3 +++
> >  doc/guides/rel_notes/deprecation.rst           | 9 +++++++++
> >  2 files changed, 12 insertions(+)
> > 
> > diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst
> > index e021cc69b6..03b5bca958 100644
> > --- a/doc/guides/prog_guide/kernel_nic_interface.rst
> > +++ b/doc/guides/prog_guide/kernel_nic_interface.rst
> > @@ -8,6 +8,9 @@ Kernel NIC Interface
> >  
> >  .. note::
> >  
> > +   KNI is deprecated and will be removed in future.
> > +   See :doc:`../rel_notes/deprecation`.
> > +
> >     For an alternative to KNI, that does not require any out-of-tree Linux kernel modules,
> >     or a custom library, see :ref:`virtio_user_as_exception_path`.
> >  
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 4e5b23c53d..e54597c591 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -48,6 +48,15 @@ Deprecation Notices
> >    in the header will not be considered as ABI anymore. This change is inspired
> >    by the RFC https://patchwork.dpdk.org/project/dpdk/list/?series=17176.
> >  
> > +* kni: The KNI kernel module and library are not recommended for use by new
> > +  applications - other technologies such as virtio-user are recommended instead.
> > +  The KNI kernel module and library will be removed from DPDK 23.11,
> > +  following the DPDK technical board
> > +  `decision <https://mails.dpdk.org/archives/dev/2021-January/197077.html>`_
> > +  and `refinement <http://mails.dpdk.org/archives/dev/2022-June/243596.html>`_.
> > +  The first steps are to add deprecation warnings
> > +  and to remove the example application from 22.11.
> > +
> 
> I wonder whether having this done as bullet points in chronological order
> might be clearer. Something like:
> 
> * kni: The KNI kernel module and library are not recommended for use by new
>   applications - other technologies such as virtio-user are recommended instead.
>   Following the DPDK technical board
>   `decision <https://mails.dpdk.org/archives/dev/2021-January/197077.html>`_
>   and `refinement <http://mails.dpdk.org/archives/dev/2022-June/243596.html>`_:
>   * The KNI example application will be removed from DPDK 22.11 release
>   * The KNI kernel module and library will be removed from the DPDK 23.11
>     release

Yes I prefer your version. Bullets are always better :)