From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA5D2A0032; Tue, 12 Jul 2022 14:28:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DF1341109; Tue, 12 Jul 2022 14:28:49 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id E31DA400D4 for ; Tue, 12 Jul 2022 14:28:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 91D045C00FF; Tue, 12 Jul 2022 08:28:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Jul 2022 08:28:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657628928; x= 1657715328; bh=TYZ8PD6pgFH0eccS5sbyePzgVM5flPPq2i1JaQDJ8vc=; b=v NlMENrA/b2Dosj4PmfO1glpanDED3DF4ZT5Bt7fG90QjLcF2SV01cATy10GgJ5j3 lJOvExh5Wl2Xj21xa9S6me8ZcCzkiKPl89qbbjTrBUHQq5g5RzANrx3hLYyup5ul QFpfAQis1Ak4TbQoIKMR+eBC3DHhEXaUM4QUnbjwuKv7/VWvsl5j1ulXdAd/RVfR gm38je6p8IYZMPsiot8M7m94QODUIhjjh3w9jFMZFbb/n1tT0vyb1SPseqCMrm6Y 2HpIpCDnn1kiaqWIml43II5HZ7nsLdA+aGWSSOSYvtC7TtEsiJVe2ITbo9KGx0zw fsGaK54/roFPpMfSEdgfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657628928; x= 1657715328; bh=TYZ8PD6pgFH0eccS5sbyePzgVM5flPPq2i1JaQDJ8vc=; b=c Xev0BdHcbvypYnhKH95UxXbdTfueTrCYaQ1XpBm+/hLtqDRW4AvPT6VwImfb0YIv JxfzWko1u5y7Jorg1Omp72EBL0zm5V0gQ1DstoumD0WBYpC8QK85pJPShq0GqWUF /7/7lwrK4+KpAFt+aIoTO8Cfh2LMEH0zKK1NUh4ZmERiqz51i5f6Ib4YWu5QXDSe ijOpJD/B+nCpF48ldScbT+ym9dK8FC9gH+cFC1ZWG4YJRwmLbJhY+8iYxZsgRxOI T3/LJwTh9UbD/96C1IzfVGhelItzqTOfTRJVtRwYXJ8TdkAzxAtld+7/eRK649Nn hf2kMZgpOLAwga6tPsbYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejhedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Jul 2022 08:28:47 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, ferruh.yigit@amd.com, david.marchand@redhat.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, chenbo.xia@intel.com, ktraynor@redhat.com, Ray Kinsella , xuemingl@nvidia.com, matan@nvidia.com Subject: Re: [PATCH] doc: announce transition to vDPA port close function Date: Tue, 12 Jul 2022 14:28:45 +0200 Message-ID: <3553248.ZuhQCC13oI@thomas> In-Reply-To: <3424161.GA8KThiCzi@thomas> References: <20210518073441.2749096-1-thomas@monjalon.net> <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com> <3424161.GA8KThiCzi@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/07/2022 14:26, Thomas Monjalon: > 12/07/2022 11:16, Maxime Coquelin: > > > > On 5/18/21 09:34, Thomas Monjalon wrote: > > > There is a layer violation in the vDPA API which encourages to destroy > > > a full device with rte_dev_remove() instead of just closing the port. > > > The plan is to introduce a new function in 21.08, promote in 21.11, > > > and deprecate rte_vdpa_get_rte_device() in 21.11. > [...] > > > +* vdpa: The vDPA API should not try to manipulate or export > > > + any ``rte_device`` object, which belongs to the bus layer. > > > + The function ``rte_vdpa_get_rte_device()`` will be deprecated in 21.11, > > > + when its usage will be replaced with a function ``rte_vdpa_close()``. > > > + The new function should enter in 21.08 and get promoted to stable in 21.11. > > > + A port close function will allow to close a single port without destroying > > > + the rest of the device. > > > > Maybe there was some changes since you posted the announce, but I don't > > see why rte_vdpa_close() would be needed. It seems the only user of > > rte_vdpa_get_rte_device() is the internal vDPA example, and it only use > > it to get and print the device name. > > You're right, it was an oversight. > So we need only to get the rte_device name. > > I propose to replace > struct rte_device *rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev); > with > const char *rte_vdpa_get_name(void); sorry, I missed a parameter :) It would be: const char *rte_vdpa_get_name(struct rte_vdpa_device *vdpa_dev); Or do you prefer "rte_vdpa_get_device_name"?