From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Shally Verma <shallyv@marvell.com>,
declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config
Date: Fri, 01 Feb 2019 12:14:09 +0100 [thread overview]
Message-ID: <3553801.FxY0opz6cb@xps> (raw)
In-Reply-To: <fc144c39-c6a5-4f13-70bb-396b1e58b6e3@nxp.com>
There is only one ack for this change.
A deprecation requires more agreement (3 valuable acks).
Other opinions?
31/01/2019 10:53, Akhil Goyal:
> On 1/17/2019 3:09 PM, Anoob Joseph wrote:
> > Add new field ff_enable in rte_cryptodev_config. This enables
> > applications to control the features enabled on the crypto device.
> >
> > Proposed new layout:
> >
> > /** Crypto device configuration structure */
> > struct rte_cryptodev_config {
> > int socket_id; /**< Socket to allocate resources on */
> > uint16_t nb_queue_pairs;
> > /**< Number of queue pairs to configure on device */
> > + uint64_t ff_enable;
> > + /**< Feature flags to be enabled on the device. Only the features set
> > + * on rte_cryptodev_info.feature_flags are allowed to be set.
> > + */
> > };
> >
> > For eth devices, rte_eth_conf.rx_mode.offloads and
> > rte_eth_conf.tx_mode.offloads fields are used by applications to
> > control the offloads enabled on the eth device. This proposal adds a
> > similar ability for the crypto device.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> >
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2019-02-01 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:39 Anoob Joseph
2019-01-17 11:37 ` Trahe, Fiona
2019-01-17 13:47 ` Anoob Joseph
2019-01-18 6:59 ` Shally Verma
2019-01-22 9:31 ` Anoob Joseph
2019-01-31 9:53 ` Akhil Goyal
2019-02-01 11:14 ` Thomas Monjalon [this message]
2019-02-01 11:49 ` Trahe, Fiona
2019-02-28 10:02 ` Akhil Goyal
2019-02-28 10:54 ` Anoob Joseph
2019-03-07 10:39 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2019-03-07 15:25 ` Trahe, Fiona
2019-03-29 14:23 ` Akhil Goyal
2019-03-29 14:23 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3553801.FxY0opz6cb@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jerinj@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).