From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D65BA1B122 for ; Fri, 1 Feb 2019 12:14:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F024421820; Fri, 1 Feb 2019 06:14:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Feb 2019 06:14:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0Z6PS7NYSMnNWQUDboBrX7zd4yYzkH1JmRD0TcXJxYY=; b=I5AMKya5P961 dG0uar5IHL93GfV0Vsi6OHlkajtn/o01eI8sdcRwjuxAm8f9McpkW8tFVum4mRR5 ff0wRhAn1kMi0nsAiCJzh3dMbFGKwHqK+GjUA+gABbo4vKWLaeeqCumtiNl8Uin6 oVnPs4kC06Y+vu5508ayhk9jzHaeo8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0Z6PS7NYSMnNWQUDboBrX7zd4yYzkH1JmRD0TcXJx YY=; b=U67XYKAtEZhUSgLktnW9f6oxK+0XGyQZ62AfbEr06K0sn6r9SCNImKnt0 WFkGmCzM+O7hdOrGGf8YSLtzxo8+/ebt0PgdRrYYAErdHpJvUDgsNJULtfrJlkse ecYEzMFxL7NDkaLRpYXB5HVVzM3O2/dpjF2Vtb1SrGJsu0Vw/6i2G/bVbxHP/tEa fKvWB+eRau+10hspRgYSeBeeW54SzUA0W4FwUwOOY6cQJaZI/NjSaFAFEpE7N1Nn Dym0Ty+tEpCNfQWozwKPoN7LSLiR9iXSaKWR62QwIWfg5EcMTUYMYBcJfJi6YOFg xIpPFM67V299SaKQPmZZJGHfaobtQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeekgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0D61C1030F; Fri, 1 Feb 2019 06:14:09 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Akhil Goyal , Anoob Joseph , Pablo de Lara , Fiona Trahe , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Shally Verma , declan.doherty@intel.com Date: Fri, 01 Feb 2019 12:14:09 +0100 Message-ID: <3553801.FxY0opz6cb@xps> In-Reply-To: References: <1547717928-21203-1-git-send-email-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 11:14:13 -0000 There is only one ack for this change. A deprecation requires more agreement (3 valuable acks). Other opinions? 31/01/2019 10:53, Akhil Goyal: > On 1/17/2019 3:09 PM, Anoob Joseph wrote: > > Add new field ff_enable in rte_cryptodev_config. This enables > > applications to control the features enabled on the crypto device. > > > > Proposed new layout: > > > > /** Crypto device configuration structure */ > > struct rte_cryptodev_config { > > int socket_id; /**< Socket to allocate resources on */ > > uint16_t nb_queue_pairs; > > /**< Number of queue pairs to configure on device */ > > + uint64_t ff_enable; > > + /**< Feature flags to be enabled on the device. Only the features set > > + * on rte_cryptodev_info.feature_flags are allowed to be set. > > + */ > > }; > > > > For eth devices, rte_eth_conf.rx_mode.offloads and > > rte_eth_conf.tx_mode.offloads fields are used by applications to > > control the offloads enabled on the eth device. This proposal adds a > > similar ability for the crypto device. > > > > Signed-off-by: Anoob Joseph > > > Acked-by: Akhil Goyal