From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id D6B3C5A70
for <dev@dpdk.org>; Tue, 20 Jan 2015 09:01:25 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id r20so20918531wiv.0
for <dev@dpdk.org>; Tue, 20 Jan 2015 00:01:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=d197Gw4FLbVrSMowL3PBLQgJ+HY9PR5OIHhHctaTNBw=;
b=KyZF04Mr1b2cxxPurYrrb9EeR+Ml3iwx7p/KSa60j95jR0KBoD2qZ0P/CamV1cCiMd
jmkCy/mfX3DkpNnrVzm+oIsZGKFnH2EUNNQz82qB51EXzmEB1p9vRzdjZvDZWiFI4M+a
Z2sDsxWjEiHXMA7MZ/wroWLDFYNqDS92nHTMPe5kfg72xQlNyCesP91U45qC7+Wz/uBZ
RVn6gRdbADDz2clX2OqSbFdPqBAZl7dTjoAsas/fwDQHrVN5Q8vJlFeEhSZ9pc07+3as
/wsLJ9v7fdN/up6hrh7HU0IFy0ml8EpOda7UqRNMLM+f64BgCFoFozQ4wXkA6Mo/+DDY
OUKg==
X-Gm-Message-State: ALoCoQl2XZ3wGW7GFNBoTIbT0EvYraP/aSFcDlojyFTQf1DfcHrtHlYePddM2p/efi2QH4zvfEec
X-Received: by 10.180.208.79 with SMTP id mc15mr6807188wic.23.1421740885758;
Tue, 20 Jan 2015 00:01:25 -0800 (PST)
Received: from xps13.localnet (111.26.90.92.rev.sfr.net. [92.90.26.111])
by mx.google.com with ESMTPSA id lq5sm119096wjb.35.2015.01.20.00.01.23
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 20 Jan 2015 00:01:25 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Tue, 20 Jan 2015 08:54:05 +0100
Message-ID: <3554949.i7emeOiECJ@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1417486760-24459-4-git-send-email-helin.zhang@intel.com>
References: <1417176852-12345-1-git-send-email-helin.zhang@intel.com>
<1417486760-24459-1-git-send-email-helin.zhang@intel.com>
<1417486760-24459-4-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash
functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 08:01:26 -0000
Hi Helin,
2014-12-02 10:19, Helin Zhang:
> Hash filter control has been implemented for i40e. It includes
> getting/setting,
> - global hash configurations (hash function type, and symmetric
> hash enable per flow type)
> - symmetric hash enable per port
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> lib/librte_ether/rte_eth_ctrl.h | 63 ++++++++
> lib/librte_pmd_i40e/i40e_ethdev.c | 294 +++++++++++++++++++++++++++++++++++++-
> 2 files changed, 355 insertions(+), 2 deletions(-)
Please, could you split ethdev and i40e parts while keeping Konstantin's ack?
[...]
> + * Each bit in valid_bit_mask[] indicates if the coresponding bit in
Typo: corresponding
[...]
> + /** Bit mask indicates if the coresponding bit is valid */
Same typo
[...]
> + /** Details of hash filter infomation */
Typo: information
> + union {
> + /* For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */
> + uint8_t enable;
> + /* Global configurations of hash filter */
> + struct rte_eth_hash_global_conf global_conf;
> + } info;
Why these comments are not doxygen'ed?
Sorry for nitpicking, that's the last review pass ;)
--
Thomas