From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_eal/common: Fix cast from pointer to integer of different size
Date: Mon, 09 Mar 2015 12:43:38 +0100 [thread overview]
Message-ID: <3556491.n1SbkH6aXT@xps13> (raw)
In-Reply-To: <F60F360A2500CD45ACDB1D700268892D0E792B73@SHSMSX101.ccr.corp.intel.com>
> > ./i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
> > cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> >
> > dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
> >
> > Type 'long long' is 64-bit in i686 platform while 'void *'
> > is 32-bit.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> > ---
> > v4 --> v3:
> > fix dstofss/bits to size_t in rte_memcpy()
> > v3 --> v2:
> > make dstofss and srcofs to be type size_t
> > casting type use uintptr_t
> >
> > v2 --> v1:
> > Remove unnecessary casting (void *)
>
> Acked-by: Wang, Zhihong <zhihong.wang@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-03-09 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 7:27 Michael Qiu
2015-03-02 11:39 ` Gonzalez Monroy, Sergio
2015-03-03 2:02 ` Qiu, Michael
2015-03-03 2:20 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-03-03 8:25 ` Pawel Wodkowski
2015-03-03 9:59 ` Qiu, Michael
2015-03-03 13:37 ` Pawel Wodkowski
2015-03-04 1:58 ` Qiu, Michael
2015-03-04 8:18 ` Pawel Wodkowski
2015-03-04 11:24 ` Qiu, Michael
2015-03-05 7:46 ` [dpdk-dev] [PATCH v3] " Michael Qiu
2015-03-05 8:25 ` Tang, HaifengX
2015-03-06 3:13 ` [dpdk-dev] [PATCH] " Michael Qiu
2015-03-09 5:38 ` Wang, Zhihong
2015-03-09 11:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3556491.n1SbkH6aXT@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).