Re: [dpdk-dev] 1.7.0 release failed to compile on linux

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Keith,

2014-08-14 21:55, Wiles, Roger Keith:
> /* #### Changed the next line to use (3,13,8) instead of (3,14,0) KeithW */
> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) )
> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
> #ifdef NETIF_F_RXHASH
> #define PKT_HASH_TYPE_L3 0
> static inline void
> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> {
>     skb->rxhash = hash;
> }
> #endif /* NETIF_F_RXHASH */
> #endif /* < RHEL7 */
> #endif /* < 3.14.0 */

I really don't understand why changing condition from
	< 3.14.0
to
	< 3.13.8
would be better?
This function appeared in 3.14.0. Maybe that Ubuntu backported it for their
12.04 version, so it must be handled with a specific Ubuntu check as it was
already done for Ubuntu 14.04:
	#if (!(UBUNTU_RELEASE_CODE == UBUNTU_RELEASE_VERSION(14,4) &&
	UBUNTU_KERNEL_CODE >= UBUNTU_KERNEL_VERSION(3,13,0,30,54)))

Please help to improve what is done in master branch by providing patches.

Note: please do not top post and try to use cite mark '>'

Thanks
-- 
Thomas