From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 214BA595B
 for <dev@dpdk.org>; Sat, 16 Aug 2014 00:38:36 +0200 (CEST)
Received: by mail-wg0-f52.google.com with SMTP id a1so2752914wgh.11
 for <dev@dpdk.org>; Fri, 15 Aug 2014 15:41:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=NGGLKOtDpll3zNB0DfZtTsooHGTDM6QRbjY//e4Cylw=;
 b=QOujEUdKdMDQoZ7NT/7shg7Fnzdjddeh7cTwhx2FW2p2m4SZs9TMCPQbnOmgqUeSGO
 MCPancgXN5UTqLawVMUehL7Rd0X32rLjCUC3zS9X+jB/XH5Nk6JAEv1+f8/Vo23sulMl
 c4mohsYNAIhcLQ2pRI3DsP1PtdN3jcZR6DaMV7e20W6X+6LwQC0G/bROW9lHm8ZWc084
 RhZV3657kggEel58TSRndPkVMN1h76w9Gv2QNnF9g/v0wTwdCdOcXYB2MDWjX57VX6xc
 udmwtjdWyV6i8PdSdHCWxVfo2tvvQ1lOInhJLU40nAjDP2uGO+rFShfSqPQv4W7iQ36+
 468A==
X-Gm-Message-State: ALoCoQnRHe6mHmyk4jXZBefS2meAYWa2lsH+wnA3Op6k6pnVJt5vgy2HMKrUocjaUMBTJ3UYEc4Y
X-Received: by 10.194.23.8 with SMTP id i8mr21688459wjf.104.1408142507069;
 Fri, 15 Aug 2014 15:41:47 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id je17sm10790114wic.22.2014.08.15.15.41.44
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 15 Aug 2014 15:41:46 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Roger Keith" <keith.wiles@windriver.com>
Date: Sat, 16 Aug 2014 00:41:38 +0200
Message-ID: <3556499.hMzHJM9L0j@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <4B613BEE-2D07-417D-ACA3-6C228FADB14E@windriver.com>
References: <53ED2DBF.4070003@gmail.com>
 <4B613BEE-2D07-417D-ACA3-6C228FADB14E@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] 1.7.0 release failed to compile on linux
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Aug 2014 22:38:36 -0000

Hi Keith,

2014-08-14 21:55, Wiles, Roger Keith:
> /* #### Changed the next line to use (3,13,8) instead of (3,14,0) KeithW */
> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) )
> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
> #ifdef NETIF_F_RXHASH
> #define PKT_HASH_TYPE_L3 0
> static inline void
> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> {
>     skb->rxhash = hash;
> }
> #endif /* NETIF_F_RXHASH */
> #endif /* < RHEL7 */
> #endif /* < 3.14.0 */

I really don't understand why changing condition from
	< 3.14.0
to
	< 3.13.8
would be better?
This function appeared in 3.14.0. Maybe that Ubuntu backported it for their
12.04 version, so it must be handled with a specific Ubuntu check as it was
already done for Ubuntu 14.04:
	#if (!(UBUNTU_RELEASE_CODE == UBUNTU_RELEASE_VERSION(14,4) &&
	UBUNTU_KERNEL_CODE >= UBUNTU_KERNEL_VERSION(3,13,0,30,54)))

Please help to improve what is done in master branch by providing patches.

Note: please do not top post and try to use cite mark '>'

Thanks
-- 
Thomas