From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vlad Zolotarov <vladz@cloudius-systems.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option
Date: Thu, 05 Mar 2015 14:19:58 +0100 [thread overview]
Message-ID: <3557886.R5Xnb4aBPR@xps13> (raw)
In-Reply-To: <1425554885-16901-6-git-send-email-vladz@cloudius-systems.com>
2015-03-05 13:28, Vlad Zolotarov:
> Enables LRO support in PMDs.
>
> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>
> ---
> config/common_linuxapp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index 97f1c9e..5b98595 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -137,6 +137,7 @@ CONFIG_RTE_MAX_ETHPORTS=32
> CONFIG_RTE_LIBRTE_IEEE1588=n
> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
> CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y
> +CONFIG_RTE_ETHDEV_LRO_SUPPORT=y
Sorry I don't really follow this ixgbe discussion but I wonder why you
would add a compile time option for this feature.
What is the benefit of disabling it?
And if really needed, this patch would make more sense merged with the
code under ifdef.
next prev parent reply other threads:[~2015-03-05 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 11:27 [dpdk-dev] [PATCH v2 0/6]: Add LRO support to ixgbe PMD Vlad Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 1/6] ixgbe: Cleanups Vlad Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 2/6] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices Vlad Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 3/6] ixgbe: Code refactoring Vlad Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 4/6] ixgbe: Unify the rx_pkt_bulk callback initialization Vlad Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option Vlad Zolotarov
2015-03-05 13:19 ` Thomas Monjalon [this message]
2015-03-05 13:39 ` Vlad Zolotarov
2015-03-05 14:01 ` Thomas Monjalon
2015-03-05 14:18 ` Vlad Zolotarov
2015-03-05 19:13 ` Thomas Monjalon
2015-03-05 20:41 ` Vladislav Zolotarov
2015-03-05 11:28 ` [dpdk-dev] [PATCH v2 6/6] ixgbe: Add LRO support Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3557886.R5Xnb4aBPR@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=vladz@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).