From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id E04025A73 for ; Thu, 5 Mar 2015 14:20:33 +0100 (CET) Received: by wesu56 with SMTP id u56so9425033wes.6 for ; Thu, 05 Mar 2015 05:20:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+JIO+1wFWO/S7kDemYswp51OCZyegtOgDLiFYyjb1y4=; b=aYfzKBIdq//5xmgZmN+bJe0mhZjWDiRqngAHNThqD5r6JhaBd8sjm1rJGDmDnyM//c eh8Bl0NMvsqZtLpxI81e9DUTgj/EAZAvA95NkWhuJJ4bAxF6dmrzduLo86IYvRPCqDdP l3hzB6rXsTRowkwuOHKNOB8YOm+LXSRZ8o0nI0YMiGHu8U430uUPdGhjaXaT9XTBulAm uy8BIgtNhn5AFnu/OV2tX60JuHsmTRWbaqlbxHAk16Sj0n7ZKxjogFSbxJ6NrT51symT dCAQc2QNWKUj7gpiutuFApKieDJ2AmOAygnPCuNemewsTvVW/0/znzLQHQiWWIj0oUOx 9shQ== X-Gm-Message-State: ALoCoQklFgOzwlJG98OjsgW3Dz8Gh+YcpbHAb/fA55cvb2c4WXgf0yUCq8gFKkrEo8cGd4MQNcDz X-Received: by 10.180.78.202 with SMTP id d10mr65629498wix.25.1425561633743; Thu, 05 Mar 2015 05:20:33 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id vh8sm10510840wjc.12.2015.03.05.05.20.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 05:20:32 -0800 (PST) From: Thomas Monjalon To: Vlad Zolotarov Date: Thu, 05 Mar 2015 14:19:58 +0100 Message-ID: <3557886.R5Xnb4aBPR@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425554885-16901-6-git-send-email-vladz@cloudius-systems.com> References: <1425554885-16901-1-git-send-email-vladz@cloudius-systems.com> <1425554885-16901-6-git-send-email-vladz@cloudius-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 5/6] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 13:20:34 -0000 2015-03-05 13:28, Vlad Zolotarov: > Enables LRO support in PMDs. > > Signed-off-by: Vlad Zolotarov > --- > config/common_linuxapp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 97f1c9e..5b98595 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -137,6 +137,7 @@ CONFIG_RTE_MAX_ETHPORTS=32 > CONFIG_RTE_LIBRTE_IEEE1588=n > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y > +CONFIG_RTE_ETHDEV_LRO_SUPPORT=y Sorry I don't really follow this ixgbe discussion but I wonder why you would add a compile time option for this feature. What is the benefit of disabling it? And if really needed, this patch would make more sense merged with the code under ifdef.