DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
@ 2020-07-27  9:41 Adam Dybkowski
  2020-08-06 14:21 ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Adam Dybkowski @ 2020-07-27  9:41 UTC (permalink / raw)
  To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski, Fan Zhang

This patch adds a deprecation notice about upcoming changes
in public API of the Scheduler PMD.

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a58a17946..dbc779a9e 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -142,3 +142,10 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``,
+  ``rte_cryptodev_scheduler_slave_detach`` and
+  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by
+  ``rte_cryptodev_scheduler_worker_attach``,
+  ``rte_cryptodev_scheduler_worker_detach`` and
+  ``rte_cryptodev_scheduler_workers_get`` accordingly.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-07-27  9:41 [dpdk-dev] [PATCH] doc: scheduler API deprecation notice Adam Dybkowski
@ 2020-08-06 14:21 ` Thomas Monjalon
  2020-08-06 17:18   ` Akhil Goyal
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-06 14:21 UTC (permalink / raw)
  To: dev
  Cc: fiona.trahe, akhil.goyal, Adam Dybkowski, Fan Zhang,
	Adam Dybkowski, stephen, anatoly.burakov, bluca

27/07/2020 11:41, Adam Dybkowski:
> This patch adds a deprecation notice about upcoming changes
> in public API of the Scheduler PMD.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> +* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``,
> +  ``rte_cryptodev_scheduler_slave_detach`` and
> +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by
> +  ``rte_cryptodev_scheduler_worker_attach``,
> +  ``rte_cryptodev_scheduler_worker_detach`` and
> +  ``rte_cryptodev_scheduler_workers_get`` accordingly.

Acked-by: Thomas Monjalon <thomas@monjalon.net>



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-06 14:21 ` Thomas Monjalon
@ 2020-08-06 17:18   ` Akhil Goyal
  2020-08-07 22:05     ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Akhil Goyal @ 2020-08-06 17:18 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: fiona.trahe, Adam Dybkowski, Fan Zhang, Adam Dybkowski, stephen,
	anatoly.burakov, bluca

> 27/07/2020 11:41, Adam Dybkowski:
> > This patch adds a deprecation notice about upcoming changes
> > in public API of the Scheduler PMD.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> > +* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``,
> > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by
> > +  ``rte_cryptodev_scheduler_worker_attach``,
> > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
I wonder how this patch got missed.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-06 17:18   ` Akhil Goyal
@ 2020-08-07 22:05     ` Thomas Monjalon
  2020-08-10  9:47       ` Dybkowski, AdamX
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-07 22:05 UTC (permalink / raw)
  To: Adam Dybkowski
  Cc: dev, fiona.trahe, Fan Zhang, stephen, anatoly.burakov, bluca,
	Akhil Goyal

06/08/2020 19:18, Akhil Goyal:
> > 27/07/2020 11:41, Adam Dybkowski:
> > > This patch adds a deprecation notice about upcoming changes
> > > in public API of the Scheduler PMD.
> > >
> > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > ---
> > > +* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``,
> > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by
> > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > 
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> I wonder how this patch got missed.
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Sorry it is missing an ack.




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-07 22:05     ` Thomas Monjalon
@ 2020-08-10  9:47       ` Dybkowski, AdamX
  2020-08-10 10:19         ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Dybkowski, AdamX @ 2020-08-10  9:47 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Trahe, Fiona, Zhang, Roy Fan, stephen, Burakov, Anatoly,
	bluca, Akhil Goyal

I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.

Can I ask why it didn't go into 20.08 then?

Adam

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Saturday, 8 August, 2020 00:05
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; stephen@networkplumber.org; Burakov,
> Anatoly <anatoly.burakov@intel.com>; bluca@debian.org; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
> 
> 06/08/2020 19:18, Akhil Goyal:
> > > 27/07/2020 11:41, Adam Dybkowski:
> > > > This patch adds a deprecation notice about upcoming changes in
> > > > public API of the Scheduler PMD.
> > > >
> > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > ---
> > > > +* scheduler: The functions
> > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > +20.11 by
> > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > I wonder how this patch got missed.
> >
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Sorry it is missing an ack.
> 
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-10  9:47       ` Dybkowski, AdamX
@ 2020-08-10 10:19         ` Thomas Monjalon
  2020-08-10 11:49           ` Trahe, Fiona
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-10 10:19 UTC (permalink / raw)
  To: Dybkowski, AdamX
  Cc: dev, Trahe, Fiona, Zhang, Roy Fan, stephen, Burakov, Anatoly,
	bluca, Akhil Goyal, bruce.richardson, john.mcnamara

10/08/2020 11:47, Dybkowski, AdamX:
> I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> also shows it has 3 ACKs.

Sorry I missed initial ack.

> Can I ask why it didn't go into 20.08 then?

Because it was completed late, I missed and nobody replied.

In general, I would like more support in last days of release,
to avoid such miss.


> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/08/2020 19:18, Akhil Goyal:
> > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > public API of the Scheduler PMD.
> > > > >
> > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > ---
> > > > > +* scheduler: The functions
> > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > +20.11 by
> > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > >
> > > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > > >
> > > I wonder how this patch got missed.
> > >
> > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > 
> > Sorry it is missing an ack.




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-10 10:19         ` Thomas Monjalon
@ 2020-08-10 11:49           ` Trahe, Fiona
  2020-08-10 12:50             ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Trahe, Fiona @ 2020-08-10 11:49 UTC (permalink / raw)
  To: Thomas Monjalon, Dybkowski, AdamX
  Cc: dev, Zhang, Roy Fan, stephen, Burakov, Anatoly, bluca,
	Akhil Goyal, Richardson, Bruce, Mcnamara, John, Trahe, Fiona

Sorry about that Thomas, Akhil, we should have chased up acks sooner. 

Given the proposed content of the patch, and the similar changes that are recommended and agreed
throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
 

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, August 10, 2020 11:19 AM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> stephen@networkplumber.org; Burakov, Anatoly <anatoly.burakov@intel.com>; bluca@debian.org;
> Akhil Goyal <akhil.goyal@nxp.com>; Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
> 
> 10/08/2020 11:47, Dybkowski, AdamX:
> > I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> > This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> > also shows it has 3 ACKs.
> 
> Sorry I missed initial ack.
> 
> > Can I ask why it didn't go into 20.08 then?
> 
> Because it was completed late, I missed and nobody replied.
> 
> In general, I would like more support in last days of release,
> to avoid such miss.
> 
> 
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/08/2020 19:18, Akhil Goyal:
> > > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > > public API of the Scheduler PMD.
> > > > > >
> > > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > > ---
> > > > > > +* scheduler: The functions
> > > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > > +20.11 by
> > > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > > >
> > > > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > > > >
> > > > I wonder how this patch got missed.
> > > >
> > > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > >
> > > Sorry it is missing an ack.
> 
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-10 11:49           ` Trahe, Fiona
@ 2020-08-10 12:50             ` Thomas Monjalon
  2020-08-12  9:52               ` Bruce Richardson
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-10 12:50 UTC (permalink / raw)
  To: Dybkowski, AdamX, Trahe, Fiona
  Cc: dev, Zhang, Roy Fan, stephen, Burakov, Anatoly, bluca,
	Akhil Goyal, Richardson, Bruce, Mcnamara, John, Trahe, Fiona,
	techboard

10/08/2020 13:49, Trahe, Fiona:
> Sorry about that Thomas, Akhil, we should have chased up acks sooner. 
> 
> Given the proposed content of the patch, and the similar changes that are recommended and agreed
> throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
> without the deprecation notice being in 20.08?

That's a question for techboard.

PS: please avoid top-posting



> From: Thomas Monjalon <thomas@monjalon.net>
> > 10/08/2020 11:47, Dybkowski, AdamX:
> > > I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> > > This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> > > also shows it has 3 ACKs.
> > 
> > Sorry I missed initial ack.
> > 
> > > Can I ask why it didn't go into 20.08 then?
> > 
> > Because it was completed late, I missed and nobody replied.
> > 
> > In general, I would like more support in last days of release,
> > to avoid such miss.
> > 
> > 
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 06/08/2020 19:18, Akhil Goyal:
> > > > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > > > public API of the Scheduler PMD.
> > > > > > >
> > > > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > > > ---
> > > > > > > +* scheduler: The functions
> > > > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > > > +20.11 by
> > > > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > > > >
> > > > > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > > > > >
> > > > > I wonder how this patch got missed.
> > > > >
> > > > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > > >
> > > > Sorry it is missing an ack.
> > 
> > 
> 
> 






^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-10 12:50             ` Thomas Monjalon
@ 2020-08-12  9:52               ` Bruce Richardson
  2020-08-12 10:22                 ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Bruce Richardson @ 2020-08-12  9:52 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: Dybkowski, AdamX, Trahe, Fiona, dev, Zhang, Roy Fan, stephen,
	Burakov, Anatoly, bluca, Akhil Goyal, Mcnamara, John, techboard

On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:
> 10/08/2020 13:49, Trahe, Fiona:
> > Sorry about that Thomas, Akhil, we should have chased up acks sooner. 
> > 
> > Given the proposed content of the patch, and the similar changes that are recommended and agreed
> > throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
> > without the deprecation notice being in 20.08?
> 
> That's a question for techboard.
> 
> PS: please avoid top-posting
> 
My initial 2c is that we should allow this, and add the required
deprecation notice to the online docs immediately. I would assume most
people use the online docs rather than building their own from the package,
therefore adding in a deprecation notice to the online versions a few days
after a release should not be a major problem IMHO.

Also, given the fact that we have once-a-year at most to apply ABI
changes, and this is the first time we are going this, so I think a little
latitude should be given! :-)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
  2020-08-12  9:52               ` Bruce Richardson
@ 2020-08-12 10:22                 ` Thomas Monjalon
  2020-08-12 10:49                   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-12 10:22 UTC (permalink / raw)
  To: Bruce Richardson
  Cc: Dybkowski, AdamX, Trahe, Fiona, dev, Zhang, Roy Fan, stephen,
	Burakov, Anatoly, bluca, Akhil Goyal, Mcnamara, John, techboard

12/08/2020 11:52, Bruce Richardson:
> On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:
> > 10/08/2020 13:49, Trahe, Fiona:
> > > Sorry about that Thomas, Akhil, we should have chased up acks sooner. 
> > > 
> > > Given the proposed content of the patch, and the similar changes that are recommended and agreed
> > > throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
> > > without the deprecation notice being in 20.08?
> > 
> > That's a question for techboard.
> > 
> > PS: please avoid top-posting
> > 
> My initial 2c is that we should allow this, and add the required
> deprecation notice to the online docs immediately. I would assume most
> people use the online docs rather than building their own from the package,
> therefore adding in a deprecation notice to the online versions a few days
> after a release should not be a major problem IMHO.
> 
> Also, given the fact that we have once-a-year at most to apply ABI
> changes, and this is the first time we are going this, so I think a little
> latitude should be given! :-)

I agree

We need more opinions from other techboard members to make it a decision.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: scheduler API deprecation notice
  2020-08-12 10:22                 ` Thomas Monjalon
@ 2020-08-12 10:49                   ` Maxime Coquelin
  2020-08-12 10:57                     ` Hemant Agrawal
  0 siblings, 1 reply; 14+ messages in thread
From: Maxime Coquelin @ 2020-08-12 10:49 UTC (permalink / raw)
  To: Thomas Monjalon, Bruce Richardson
  Cc: Dybkowski, AdamX, Trahe, Fiona, dev, Zhang, Roy Fan, stephen,
	Burakov, Anatoly, bluca, Akhil Goyal, Mcnamara, John, techboard



On 8/12/20 12:22 PM, Thomas Monjalon wrote:
> 12/08/2020 11:52, Bruce Richardson:
>> On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:
>>> 10/08/2020 13:49, Trahe, Fiona:
>>>> Sorry about that Thomas, Akhil, we should have chased up acks sooner. 
>>>>
>>>> Given the proposed content of the patch, and the similar changes that are recommended and agreed
>>>> throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
>>>> without the deprecation notice being in 20.08?
>>>
>>> That's a question for techboard.
>>>
>>> PS: please avoid top-posting
>>>
>> My initial 2c is that we should allow this, and add the required
>> deprecation notice to the online docs immediately. I would assume most
>> people use the online docs rather than building their own from the package,
>> therefore adding in a deprecation notice to the online versions a few days
>> after a release should not be a major problem IMHO.
>>
>> Also, given the fact that we have once-a-year at most to apply ABI
>> changes, and this is the first time we are going this, so I think a little
>> latitude should be given! :-)
> 
> I agree
> 
> We need more opinions from other techboard members to make it a decision.
> 
> 

I agree too, let's give a bit more flexibility for the deprecation
notice.

Maxime


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: scheduler API deprecation notice
  2020-08-12 10:49                   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
@ 2020-08-12 10:57                     ` Hemant Agrawal
  2020-08-12 12:23                       ` Thomas Monjalon
  0 siblings, 1 reply; 14+ messages in thread
From: Hemant Agrawal @ 2020-08-12 10:57 UTC (permalink / raw)
  To: Maxime Coquelin, Thomas Monjalon, Bruce Richardson
  Cc: Dybkowski, AdamX, Trahe, Fiona, dev, Zhang, Roy Fan, stephen,
	Burakov, Anatoly, bluca, Akhil Goyal, Mcnamara, John, techboard

> -----Original Message-----
> From: techboard <techboard-bounces@dpdk.org> On Behalf Of Maxime
> Coquelin
> 
> On 8/12/20 12:22 PM, Thomas Monjalon wrote:
> > 12/08/2020 11:52, Bruce Richardson:
> >> On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:
> >>> 10/08/2020 13:49, Trahe, Fiona:
> >>>> Sorry about that Thomas, Akhil, we should have chased up acks sooner.
> >>>>
> >>>> Given the proposed content of the patch, and the similar changes
> >>>> that are recommended and agreed throughout DPDK do you think an
> >>>> exception can be made and that this change can get into 20.11 even
> without the deprecation notice being in 20.08?
> >>>
> >>> That's a question for techboard.
> >>>
> >>> PS: please avoid top-posting
> >>>
> >> My initial 2c is that we should allow this, and add the required
> >> deprecation notice to the online docs immediately. I would assume
> >> most people use the online docs rather than building their own from
> >> the package, therefore adding in a deprecation notice to the online
> >> versions a few days after a release should not be a major problem IMHO.
> >>
> >> Also, given the fact that we have once-a-year at most to apply ABI
> >> changes, and this is the first time we are going this, so I think a
> >> little latitude should be given! :-)
> >
> > I agree
> >
> > We need more opinions from other techboard members to make it a
> decision.
> >
> >
> 
> I agree too, let's give a bit more flexibility for the deprecation notice.
> 
> Maxime

+1
Hemant

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: scheduler API deprecation notice
  2020-08-12 10:57                     ` Hemant Agrawal
@ 2020-08-12 12:23                       ` Thomas Monjalon
  2020-08-12 15:25                         ` Stephen Hemminger
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-08-12 12:23 UTC (permalink / raw)
  To: Maxime Coquelin, Bruce Richardson, Dybkowski, AdamX, Trahe,
	Fiona, Hemant Agrawal
  Cc: dev, dev, Zhang, Roy Fan, stephen, Burakov, Anatoly, bluca,
	Akhil Goyal, Mcnamara, John, techboard

12/08/2020 12:57, Hemant Agrawal:
> > -----Original Message-----
> > From: techboard <techboard-bounces@dpdk.org> On Behalf Of Maxime
> > Coquelin
> > 
> > On 8/12/20 12:22 PM, Thomas Monjalon wrote:
> > > 12/08/2020 11:52, Bruce Richardson:
> > >> On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:
> > >>> 10/08/2020 13:49, Trahe, Fiona:
> > >>>> Sorry about that Thomas, Akhil, we should have chased up acks sooner.
> > >>>>
> > >>>> Given the proposed content of the patch, and the similar changes
> > >>>> that are recommended and agreed throughout DPDK do you think an
> > >>>> exception can be made and that this change can get into 20.11 even
> > without the deprecation notice being in 20.08?
> > >>>
> > >>> That's a question for techboard.
> > >>>
> > >>> PS: please avoid top-posting
> > >>>
> > >> My initial 2c is that we should allow this, and add the required
> > >> deprecation notice to the online docs immediately. I would assume
> > >> most people use the online docs rather than building their own from
> > >> the package, therefore adding in a deprecation notice to the online
> > >> versions a few days after a release should not be a major problem IMHO.
> > >>
> > >> Also, given the fact that we have once-a-year at most to apply ABI
> > >> changes, and this is the first time we are going this, so I think a
> > >> little latitude should be given! :-)
> > >
> > > I agree
> > >
> > > We need more opinions from other techboard members to make it a
> > decision.
> > >
> > >
> > 
> > I agree too, let's give a bit more flexibility for the deprecation notice.
> > 
> > Maxime
> 
> +1
> Hemant

I've applied the patch after 20.11-rc0.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: scheduler API deprecation notice
  2020-08-12 12:23                       ` Thomas Monjalon
@ 2020-08-12 15:25                         ` Stephen Hemminger
  0 siblings, 0 replies; 14+ messages in thread
From: Stephen Hemminger @ 2020-08-12 15:25 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: Maxime Coquelin, Bruce Richardson, Dybkowski, AdamX, Trahe,
	Fiona, Hemant Agrawal, dev, Zhang, Roy Fan, Burakov, Anatoly,
	bluca, Akhil Goyal, Mcnamara, John, techboard

On Wed, 12 Aug 2020 14:23:51 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 12/08/2020 12:57, Hemant Agrawal:
> > > -----Original Message-----
> > > From: techboard <techboard-bounces@dpdk.org> On Behalf Of Maxime
> > > Coquelin
> > > 
> > > On 8/12/20 12:22 PM, Thomas Monjalon wrote:  
> > > > 12/08/2020 11:52, Bruce Richardson:  
> > > >> On Mon, Aug 10, 2020 at 02:50:57PM +0200, Thomas Monjalon wrote:  
> > > >>> 10/08/2020 13:49, Trahe, Fiona:  
> > > >>>> Sorry about that Thomas, Akhil, we should have chased up acks sooner.
> > > >>>>
> > > >>>> Given the proposed content of the patch, and the similar changes
> > > >>>> that are recommended and agreed throughout DPDK do you think an
> > > >>>> exception can be made and that this change can get into 20.11 even  
> > > without the deprecation notice being in 20.08?  
> > > >>>
> > > >>> That's a question for techboard.
> > > >>>
> > > >>> PS: please avoid top-posting
> > > >>>  
> > > >> My initial 2c is that we should allow this, and add the required
> > > >> deprecation notice to the online docs immediately. I would assume
> > > >> most people use the online docs rather than building their own from
> > > >> the package, therefore adding in a deprecation notice to the online
> > > >> versions a few days after a release should not be a major problem IMHO.
> > > >>
> > > >> Also, given the fact that we have once-a-year at most to apply ABI
> > > >> changes, and this is the first time we are going this, so I think a
> > > >> little latitude should be given! :-)  
> > > >
> > > > I agree
> > > >
> > > > We need more opinions from other techboard members to make it a  
> > > decision.  
> > > >
> > > >  
> > > 
> > > I agree too, let's give a bit more flexibility for the deprecation notice.
> > > 
> > > Maxime  
> > 
> > +1
> > Hemant  
> 
> I've applied the patch after 20.11-rc0.

I am ok with changing this for 20.11 since there aren't a lot of users of
this subsystem and the change should be API compatiable

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-08-12 15:25 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27  9:41 [dpdk-dev] [PATCH] doc: scheduler API deprecation notice Adam Dybkowski
2020-08-06 14:21 ` Thomas Monjalon
2020-08-06 17:18   ` Akhil Goyal
2020-08-07 22:05     ` Thomas Monjalon
2020-08-10  9:47       ` Dybkowski, AdamX
2020-08-10 10:19         ` Thomas Monjalon
2020-08-10 11:49           ` Trahe, Fiona
2020-08-10 12:50             ` Thomas Monjalon
2020-08-12  9:52               ` Bruce Richardson
2020-08-12 10:22                 ` Thomas Monjalon
2020-08-12 10:49                   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-08-12 10:57                     ` Hemant Agrawal
2020-08-12 12:23                       ` Thomas Monjalon
2020-08-12 15:25                         ` Stephen Hemminger

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git