From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] tools brainstorming
Date: Fri, 20 Mar 2015 15:51:11 +0100 [thread overview]
Message-ID: <3571725.20GtF5MAnU@xps13> (raw)
Hi,
As you probably know, a MAINTAINERS file is being filled, which is a great
help to request patch reviews and discuss design with the knowledgeable people
of this young DPDK community:
http://dpdk.org/browse/dpdk/tree/MAINTAINERS
The next step is to clearly define what are the guidelines to review a patch
and accept it. So let's write a new document CONTRIBUTING (or another
capitalized file ;). It will help contributors to do the right checks
before submitting, and will help reviewers.
As we are lazy developers, writing guidelines is not enough. It must be
coupled with the integration of some tools. Let's work on these ones:
- make autotests easier and faster to run for smoke testing
- automated basic testpmd check
- build check with various options combinations
- abi check (started with validate-abi.sh)
- static analyze (clang, free online coverity)
- comment check (doxygen, codespell, kerspell)
- format check (customized checkpatch)
I'm sure this last item will trigger a lot of debate.
Actually, format checking can be of two kinds:
- commit message formatting (how to write the title, how and when adding
Fixes tag, Signed-off-by tag, etc);
- coding style might deserve its own document.
At the end, we should be able to pass a "make check" on the whole code and
a "make checkpatch" before submitting.
Then the result of these tools could be automatically checked and displayed
in patchwork or in an adapted version of qemu's patchew. But this is
obviously a later step.
When all automatic lights are green and human design review is properly done,
the patch can be acknowledged by one or many reviewers. Speaking about that,
it would be helpful to have a column in our patchwork to summarize the counts
of tests, reviews and acknowledgements.
Comments and contributions are more than welcome!
next reply other threads:[~2015-03-20 14:51 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:51 Thomas Monjalon [this message]
2015-03-20 15:07 ` Butler, Siobhan A
2015-03-23 16:18 ` Thomas Monjalon
2015-03-23 16:50 ` Butler, Siobhan A
2015-03-23 17:35 ` Neil Horman
2015-03-23 23:38 ` Matthew Hall
2015-03-20 15:16 ` Neil Horman
2015-03-23 16:22 ` Jim Thompson
2015-03-23 17:44 ` Neil Horman
2015-03-23 21:56 ` Jim Thompson
2015-03-23 23:01 ` Neil Horman
2015-03-23 16:26 ` Thomas Monjalon
2015-03-20 15:18 ` Simon Kågström
2015-03-23 16:29 ` Thomas Monjalon
2015-03-24 8:31 ` Simon Kågström
2015-03-23 8:41 ` Cao, Waterman
2015-03-23 16:18 ` Mcnamara, John
2015-04-08 10:43 ` Butler, Siobhan A
2015-04-08 11:43 ` Neil Horman
2015-04-08 12:16 ` Butler, Siobhan A
2015-04-08 12:20 ` Butler, Siobhan A
2015-04-08 13:11 ` Neil Horman
2015-04-08 14:40 ` Butler, Siobhan A
2015-04-08 15:39 ` Neil Horman
2015-04-08 22:29 ` Jay Rolette
2015-04-08 22:38 ` Stephen Hemminger
2015-04-09 16:31 ` Jay Rolette
2015-04-09 19:16 ` Neil Horman
2015-04-09 19:38 ` Jay Rolette
2015-04-09 20:14 ` Neil Horman
2015-04-09 21:10 ` Wiles, Keith
2015-04-09 21:23 ` Stephen Hemminger
2015-04-09 21:29 ` Wiles, Keith
2015-04-10 0:16 ` Neil Horman
2015-04-10 0:26 ` Neil Horman
2015-04-10 1:49 ` Wiles, Keith
2015-04-10 11:41 ` Neil Horman
2015-04-10 14:43 ` Wiles, Keith
2015-04-08 14:16 ` Wiles, Keith
2015-04-14 14:50 ` Bruce Richardson
2015-04-08 15:21 ` Wiles, Keith
2015-04-08 15:53 ` Wiles, Keith
2015-04-08 16:16 ` Thomas Monjalon
2015-04-08 16:25 ` Wiles, Keith
2015-04-08 19:54 ` Butler, Siobhan A
2015-04-14 14:21 ` Bruce Richardson
2015-04-14 14:38 ` Neil Horman
2015-04-14 14:47 ` Thomas Monjalon
2015-04-14 14:54 ` Bruce Richardson
2015-04-14 14:52 ` Bruce Richardson
2015-04-14 15:24 ` Thomas Monjalon
2015-04-14 16:19 ` Wiles, Keith
2015-04-14 18:52 ` Wiles, Keith
2015-04-08 18:16 ` Stephen Hemminger
2015-04-08 18:58 ` Matthew Hall
2015-04-08 22:12 ` Stephen Hemminger
2015-04-08 19:51 ` Butler, Siobhan A
2015-04-14 15:29 ` Bruce Richardson
2015-04-08 21:55 ` Don Provan
2015-04-13 15:02 ` Neil Horman
2015-04-13 23:44 ` Stephen Hemminger
2015-04-16 10:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3571725.20GtF5MAnU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).