From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id A0872569C for ; Fri, 20 Mar 2015 15:51:51 +0100 (CET) Received: by wibdy8 with SMTP id dy8so19127413wib.0 for ; Fri, 20 Mar 2015 07:51:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:organization :user-agent:mime-version:content-transfer-encoding:content-type; bh=NyVsJONMJJ3E7nIhDvvVgrZONeKm4bTaRzl+eY3KGjM=; b=f0fsexu0J9B9bcsEsKuMKddTUuiCB3+v9Zx0bkclG432QTZ4Gs8i+7Br9XWVdIdfj7 keFmWdqhtdurrSfuwr1mLc6k4VXPK4uCm7espuqnCwFRc/1lox8LtJwMaigWp4FA/Urc /6Sgg7LtyO/D5am9gj4CgvmFY9RQWEWdU1m4a4zZQgzH3sH0C8r7BWsPQrU3yPogo0t+ U+g24Y6i2EimLeoTlTC9UVSAyeeFP291G5tTScboqiAJR5H5x0U6+k1BMBJTrr/LGmwX 8rE9pMXEaMQ2aktMMoltBora4mL7priW2p71uECUfL2w/xUuofOS386kaSNHV61CVfuG he/Q== X-Gm-Message-State: ALoCoQkB7Vqwbj/C4LntXbO0W3/zsTu+MT9LNxGeNvrUDMfgC3a4A9DIRY65bHnAW8QizGxEOJFF X-Received: by 10.180.81.7 with SMTP id v7mr5953079wix.27.1426863111454; Fri, 20 Mar 2015 07:51:51 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id m4sm6677578wjb.25.2015.03.20.07.51.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 07:51:50 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Fri, 20 Mar 2015 15:51:11 +0100 Message-ID: <3571725.20GtF5MAnU@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 14:51:51 -0000 Hi, As you probably know, a MAINTAINERS file is being filled, which is a great help to request patch reviews and discuss design with the knowledgeable people of this young DPDK community: http://dpdk.org/browse/dpdk/tree/MAINTAINERS The next step is to clearly define what are the guidelines to review a patch and accept it. So let's write a new document CONTRIBUTING (or another capitalized file ;). It will help contributors to do the right checks before submitting, and will help reviewers. As we are lazy developers, writing guidelines is not enough. It must be coupled with the integration of some tools. Let's work on these ones: - make autotests easier and faster to run for smoke testing - automated basic testpmd check - build check with various options combinations - abi check (started with validate-abi.sh) - static analyze (clang, free online coverity) - comment check (doxygen, codespell, kerspell) - format check (customized checkpatch) I'm sure this last item will trigger a lot of debate. Actually, format checking can be of two kinds: - commit message formatting (how to write the title, how and when adding Fixes tag, Signed-off-by tag, etc); - coding style might deserve its own document. At the end, we should be able to pass a "make check" on the whole code and a "make checkpatch" before submitting. Then the result of these tools could be automatically checked and displayed in patchwork or in an adapted version of qemu's patchew. But this is obviously a later step. When all automatic lights are green and human design review is properly done, the patch can be acknowledged by one or many reviewers. Speaking about that, it would be helpful to have a column in our patchwork to summarize the counts of tests, reviews and acknowledgements. Comments and contributions are more than welcome!