From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9471341FD1; Wed, 30 Aug 2023 18:23:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75A6D4027F; Wed, 30 Aug 2023 18:23:57 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id B59FA4027B for ; Wed, 30 Aug 2023 18:23:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2E32432002E8; Wed, 30 Aug 2023 12:23:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Aug 2023 12:23:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693412633; x=1693499033; bh=GChrgwPyNWFOSLKVvsmu2gxNpkBna2fz3aa ASmJKVUM=; b=Yr86C4lTQSVkRUXjZzr7CZyAQ2KFQOHa2o7IOAx9yRARyl+9ta+ MKV3marlflZ915YbHtP8gntg7v3XssJY7+nmbtn3oHFjZ8Hw21Aoi+3JS1DOo5fa mnNKwLNMtE98MeEHlYYNnVyUuvbcJN0YZnRRJMzR/mMuiAd8YYTonL53mEozTAlx vdQbz15Zo5bdQwwnZrMLLtVObEJ5tj/7eKi/M8OFAivQQU5pVUJ8N5h4+nzga/Ct xXMG8GzbTjenNh4mb4eN3g278CAMJt2SQrpjmqQvtoOfHhs/bxBNBogY7liHyyFC +fqhjoHZ4IJniJ0tlJh/TRw5LXwTCtxXGvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693412633; x=1693499033; bh=GChrgwPyNWFOSLKVvsmu2gxNpkBna2fz3aa ASmJKVUM=; b=JGes/gpvnhYu18Vm25IEjbbenWrgwS3RWPeJySswc8rT1mzR5+I gyUaJJn3ozKbZqNcbBZQd5uOXpoNEDF5Okl1gtOEnFzNPKMjLPnOwsvbYeIKn4OR i4C3cBsc/HKLz46l5yJajf1u+d2J1n9/8cNBjaNue0Q4eYFeQOEdQ8HnI5vOqG4J wlN5VabkGVEKKV5IJPdZ3DLD7F8m07+4nlWW5tkZ5jb//dCTvorMbInDWgAh8K53 g8uJ4c6DOXkTALfFFw5kzFgpdnb5gaz6C4wk1jc7W37599jvJ7mNVylmQhAL4vpO r6wN8tp9E/88lG9TvILphn5OH5Yy9AeMoNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhtedu udevtdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 12:23:52 -0400 (EDT) From: Thomas Monjalon To: Ankur Dwivedi , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: Stephen Hemminger , Jerin Jacob Kollanukkaran , dev@dpdk.org Subject: Re: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch Date: Wed, 30 Aug 2023 18:23:51 +0200 Message-ID: <3574329.R56niFO833@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B25@smartserver.smartshare.dk> References: <20230303155811.2751210-1-adwivedi@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35D87B25@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/08/2023 16:46, Morten Br=F8rup: > > From: Ankur Dwivedi [mailto:adwivedi@marvell.com] > > Sent: Monday, 21 August 2023 15.54 > >=20 > > >From: Stephen Hemminger > > >Sent: Thursday, May 18, 2023 9:04 PM > > > > > >---------------------------------------------------------------------- > > >On Thu, 18 May 2023 13:45:29 +0000 > > >Ankur Dwivedi wrote: > > > > > >> >From: Ankur Dwivedi > > >> >Sent: Tuesday, March 7, 2023 5:35 PM > > >> > > > >> >This patch adds a validation in checkpatch tool, to check if a > > >> >tracepoint is present in any new function added in cryptodev, > > ethdev, > > >> >eventdev and mempool library. > > >> > > > >> >In this patch, the build_map_changes function is copied from > > >> >check-symbol- change.sh to check-tracepoint.sh. The > > >> >check-tracepoint.sh script uses build_map_changes function to create > > a > > >map of functions. > > >> >In the map, the newly added functions, added in the experimental > > >> >section are identified and their definition are checked for the > > >> >presence of tracepoint. The checkpatch return error if the > > tracepoint is not > > >present. > > >> > > > >> >For functions for which trace is not needed, they can be added to > > >> >devtools/trace-skiplist.txt file. The above tracepoint check will be > > >> >skipped for them. > > >> > > > >> >Signed-off-by: Ankur Dwivedi > > > > > >Given the amount of string processing, it would be more readable in > > python. > > >That is not a show stopper, just a suggestion. > >=20 > > Hi Thomas, > >=20 > > Please let me know if the shell script in this patch is fine or would a > > python implementation would be more preferable. In general, I wonder how much the check is useful compared to the complexit= y. > The bigger question is: Do we really want to change tracepoints in functi= ons from opt-in to opt-out? Yes that's the question: should traces be mandatory in some libs? > In my opinion, opt-in for trace is more appropriate. There was some work to add traces everywhere in few libs, so why not mainta= ining this state? I don't really like adding a skip list as one more burden for future author= s. > Nonetheless, having a tool to check for tracepoint presence might still b= e useful for library reviewers and maintainers. And such a tool might be us= eful for any library, not just the few libraries suggested by this patch.