From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id D29229AC7 for ; Tue, 3 Feb 2015 09:28:24 +0100 (CET) Received: by mail-we0-f172.google.com with SMTP id q59so43432012wes.3 for ; Tue, 03 Feb 2015 00:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=A0WMmJIVVWSkv9YnFxq6iKS8Y8njwifVlop7w9TVCyE=; b=K7qL9QZ5PxlGjoE41OJq60QCXcRNHoLFPTC8QWpwezUyWm9MGU+dmaW901E7EKNU4o X1aTWc4AOqCsLm5+4nKlAPuMVsV6z2kBz93y3UQPAaD5BZ/ZtDxI5y0D32MpLzBY3vD5 EXG/YfKl59NPF9/x2jmZHXPqro6D/AcTGfU5jlOWgqRVsz13M0J4YBpYc1eAd3VniAwv bwp13B09cocLd4y8TITLqHpM4mFVHCI/M1baFrymm9cnO6ZSQfU9waLo+KFsREyCQJDF a4OajBBZSVbguNT+ui0uk9KfrGzj92CmUYopM+k6JOlPfWo/FL701o7Yo28aVlE1efGz 0V2A== X-Gm-Message-State: ALoCoQl4oYWqIvDo7LUVMKpJG48MTRN2kmQ6ayiP553ijX1qlWEx+K42CKElTcQCZmm+zyrPXFPm X-Received: by 10.194.91.199 with SMTP id cg7mr53770343wjb.114.1422952104683; Tue, 03 Feb 2015 00:28:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id mx4sm23463245wic.24.2015.02.03.00.28.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Feb 2015 00:28:23 -0800 (PST) From: Thomas Monjalon To: David Marchand Date: Tue, 03 Feb 2015 09:27:56 +0100 Message-ID: <3575894.8HcOK8U9Qc@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1422554832-30093-1-git-send-email-thomas.monjalon@6wind.com> <1422899093-20207-2-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: sort and align options lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 08:28:25 -0000 2015-02-03 07:26, David Marchand: > Two little comments. > > On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon > wrote: > > @@ -578,37 +579,36 @@ eal_check_common_options(struct internal_config > > *internal_cfg) > > void > > eal_common_usage(void) > > { > > - printf("-c COREMASK -n NUM [-m NB] [-r NUM] [-b ]" > > - "[--proc-type primary|secondary|auto]\n\n" > > + printf("-c COREMASK|-l CORELIST -n CHANNELS [options]\n\n" > > "EAL common options:\n" > > - " -c COREMASK : A hexadecimal bitmask of cores to run on\n" > > - " -l CORELIST : List of cores to run on\n" > > - " The argument format is [-c2][,c3[-c4],...]\n" > [snip] > > + " -n NUM Number of memory channels\n" > > Not really a problem, but for consistency : here, you are talking about > NUM, while at first, you wrote -n CHANNELS. Yes you're right. I changed headline but not the description of this option. Will do. > [snip] > > /* first long only option value must be >= 256, so that we won't > > * conflict with short options */ > > OPT_LONG_MIN_NUM = 256, > > -#define OPT_HUGE_DIR "huge-dir" > > - OPT_HUGE_DIR_NUM = OPT_LONG_MIN_NUM, > > -#define OPT_MASTER_LCORE "master-lcore" > > +#define OPT_BASE_VIRTADDR "base-virtaddr" > > + OPT_BASE_VIRTADDR_NUM, > > Why skip the first entry ? > Afaik, OPT_BASE_VIRTADDR_NUM will be set to 257, is it to avoid having this > = OPT_LONG_MIN_NUM moved anytime we add a new long option at the top of the > enum ? Exactly, yes. I think we don't care what is the first number. It doesn't deserve a painful assignment. > The rest looks good to me. > Acked-by: David Marchand Thanks -- Thomas