DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Timothy Redaelli <tredaelli@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	erik.g.carrillo@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: fix build without timer
Date: Fri, 05 Jul 2019 10:48:51 +0200	[thread overview]
Message-ID: <3576569.IUlI3zvMQ7@xps> (raw)
In-Reply-To: <20190704162700.GE439@bricha3-MOBL.ger.corp.intel.com>

04/07/2019 18:27, Bruce Richardson:
> On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote:
> > The action for timer_secondary_spawn_wait should be enabled only when
> > CONFIG_RTE_LIBRTE_TIMER is enabled.
> > 
> > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> > Cc: erik.g.carrillo@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> 
> Is there a reason why DPDK can't always be built with the timer library? It
> doesn't have any external dependencies, and having the ability to turn on
> and off various libraries individually in the build makes validating the
> combinations problematic.

Every libraries can be disabled in the "make" build system.
It allows to build a small DPDK.
Anyway, this capability is removed in the "meson" build system.

Applied, thanks



      reply	other threads:[~2019-07-05  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 15:36 Timothy Redaelli
2019-07-04 16:27 ` Bruce Richardson
2019-07-05  8:48   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3576569.IUlI3zvMQ7@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=stable@dpdk.org \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).