From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 378F7255 for ; Mon, 23 Apr 2018 22:56:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AD7EC21B99; Mon, 23 Apr 2018 16:56:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Apr 2018 16:56:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Y14/Ew0jnwvjWAVvIW3RrznYTr tebbnxDE/jq9SIvqY=; b=PBf2LmR+Ec0l0tT8t0NYbfrKgoOEL5EA7PGyqAI4r2 hplUAWSBuLcSxksqNbU77ZEIYDRjU5Sk416M2JYAHPzjgSvB2ZkJ06E9LheYilib BnApMtL1OPwCJpIdFWTVwqLeY8v172dEgMJkszTKLuSrnlXA0uY/hLhTpdYIEbdq k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Y14/Ew 0jnwvjWAVvIW3RrznYTrtebbnxDE/jq9SIvqY=; b=bcJR0KjhyACi+lFPouwjKi XrZLtHU8ckalEGBZ/dI0gKVXi+eqMzoU8lL0vXWOh1T2jO1XUct127vicUtEyFFe 2i/wu6ShUfkDFmbt2YCAUEks5soZPmDrOhmz6wFRv1g5QarfTtuvZLbJgoCHfj9R PUc0LmeG2jP3LanrWDXM+5VPB6Htf1GOO+AFDlESRh5aUKhp8IiAgqGMrQ9p/PWj dw55IkaBg4jbIeuTf6dj4/LVDVTlLy/svJYDleXwADtQRvwar/vL4NzFY1vPjSkO g10jM4jHnI3sBHtWadmyUfoAj+0Bn/FkGBtXP3SPBh+piHfgkinYbWtszKEMWnSg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 187B1E5088; Mon, 23 Apr 2018 16:56:29 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Mon, 23 Apr 2018 22:56:27 +0200 Message-ID: <3587843.k4HvfGJhFO@xps> In-Reply-To: <20180423130902.183473-1-david.hunt@intel.com> References: <20180410150804.8774-1-david.hunt@intel.com> <20180423130902.183473-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mk: fix make defconfig on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 20:56:30 -0000 23/04/2018 15:09, David Hunt: > On FreeBSD, make defconfig generates the config as > "defconfig_x86_64-bsdapp-", which does not resolve to any known > config file. > > On FreeBSD, we get amd64 out of "uname -m", which was not handled by > the list of checks, but which now resolves to x86_64-native. > > Then we run '$CC --version', and use grep -o with the list of known > compilers, and set to either gcc, icc or clang. Grep's '-o' option > returns the matched word rather than the whole line, making the > result easier to use. > > The remaining code in the patch then takes ${compiler}, the "uname -m" > output and assembles them all together into a valid freebsd config name, > i.e. "defconfig_x86_64-native-bsdapp-clang". > > v3 fixes: > Removed the call to $CC outside of the defconfig rule. > No longer breaks the 'make -R showversion'. > Simplified working out the compiler name using grep -o. > > Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig") > > Tested-by: Anatoly Burakov > Signed-off-by: David Hunt Applied, thanks