From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E925A034F; Mon, 11 Oct 2021 15:12:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DA1840150; Mon, 11 Oct 2021 15:12:48 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 82F9A40142 for ; Mon, 11 Oct 2021 15:12:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10133"; a="226769189" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="226769189" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 06:12:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="490470016" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 11 Oct 2021 06:12:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 06:12:30 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 06:12:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 06:12:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hg8hNv0VXXoqheLNgPSp3Z+S0llLxrTf6B3yHamRugB9qe4NNxUBWBC/pn8V4TjhRcBt0rNcbnj9ADV2d0upl17GjvhCOPeoYnr8BC0rybqT/3UavqzW9ceWAq1W7ZwOcxeQOOcIAiB3M1T5n7TMDxaK+ldehiWpXgLy5ZFIgyXQ8Cxqi1vosB37ugZIJ4U2mHy4L9PakH0X+oMOIJxzDBOvJgVzsf3FEL37c2lz4PF9aAzQePeM2eNcChGyvyqSMt1rKwqiYl+Gvyy4sWGF3NGrFJIpXY7dp/aUPk1HOzBLKxDhN161u75wwACrh/ZQnurJIwDFp8uwTQ9z4rqZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yx3X2D4LZgeTq/Mld6MvFMSUmPYC5cIRp00SZoyOUmQ=; b=BRJRwYFsZRCfzm9YHypXPJwVX7aQjVBMvlNJkz/Ii+bUMDW0O1aytowQRhdisq+PBiF6uWEpSSxUoLsKXWdQoKsfet/M6TSVhZ1rCQZVwJhxhVBMF2YuYdPBFPKqk6/zobhUJUSGZ+wdQYbZLy0ewYAnpYHvIIKDOhsCptZO8PJDSPbIBd3M+k/POlzLHFhDyCENO4NAy1h13As5HolyJiJq8KoUaiiWE56leEauV5gUhs1s0brp3cKzRNUVXx4p7AmVYPnaenrucn/ktg7KOSErO7Cp9A/x8BR+MlVOt1vP/nmswzVHfEun4htYHr89tEmynxlU4vVlgMw/n5GhSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yx3X2D4LZgeTq/Mld6MvFMSUmPYC5cIRp00SZoyOUmQ=; b=QHGCIXKeSfazED4CK1GWfIRt55MSOGNGnZ73tZL4Lm2z1rroApVEwdwKLoGXaiKRI6i/xJok8bgEFPxmGfbm8uwKuNcZ5u20gTSV4z59+ZdpQH0BuqZgzg89705BFV1vFebL14THGTV1Ou0YBxfQZat4P38wZamLFaMOcVPu6dA= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5144.namprd11.prod.outlook.com (2603:10b6:510:3e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 13:12:16 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 13:12:16 +0000 Message-ID: <3587ab85-771a-d72b-bf9e-dbaf722f24b1@intel.com> Date: Mon, 11 Oct 2021 14:11:59 +0100 Content-Language: en-US To: Thomas Monjalon , Xueming Li CC: , Andrew Rybchenko , "Singh Aman Deep" , Ajit Khaparde , Somnath Kotur , Igor Russkikh , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Chas Williams , "Min Hu (Connor)" , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , Long Li , Martin Spinler , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Jerin Jacob , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Keith Wiles , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang References: <20210727034134.20556-1-xuemingl@nvidia.com> <20211006111822.437298-1-xuemingl@nvidia.com> <20211006111822.437298-3-xuemingl@nvidia.com> <1980368.fPBH8iPQn9@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1980368.fPBH8iPQn9@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend Transport; Mon, 11 Oct 2021 13:12:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75704400-778d-4e5b-9821-08d98cb8bebb X-MS-TrafficTypeDiagnostic: PH0PR11MB5144: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IeZuNS5wEjRLB3DluUlhOyo/XKfpYAO0NjH/Xtb7lbJ30D9cbI8mgW/ou5VP8V/c23l9TlkP5N5pRXorrfQaIyMDoKmSl0cRmyU1x8NG+5ooqzOV70/omAO17pxUBJJ5lLr3+qmYnPNPmmtkr+9Bd7LJG6XzA6mGuwMhDgkLS2vTi9H6r+wAYCoE18EUE6B1kzHbNsxY/BCauOMCqNmExmR49ocO8PB6siIW69MsYyDNeuAp76l5ctofJHrRHQxMtJihiSxGeIrKPXC0Vy8HKopw0ILWvVA0PEaA1r2n9JDUl/IqZEyeaybfTyOpseNW+Q0MrXH8qWO6TrMkdqxjhqnfrFU8aB4kfbQC+1VFOfG4d5Fh8sj7qLpxpCHpUXSyTDHO0hWYLZF3M5kBTcVcUptIU13c4KXmIv+zHGAq5BaH0MHCujkMIvFto4ub1V2/hHxw/nDrigfhiZfTPcpjzfiZnfiZ6oaWDn89wjNwoBtm2S0N/cb8XLkBzZMCR1yv09bNO7V+ueHtT8gcwVOk/QkB4DTDLonn9M4pQJ2bE5BIgvpgMJqNBD0JA8qRCpznya2QStiMPQrQwhLPzwfwldKtgtRYftIBmN5zjMjqI0WJ7g+KrOl9BBEjK/2U3+tDNpIFyk6r+vBlvqZVQGFtigjSynY7vOKbzXlsMNDRMQDEmMGX4WyqaQ8QGENK8QkJrTrjXZkrVLzzVNOLfdHYAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(2906002)(66476007)(66556008)(6666004)(44832011)(4326008)(36756003)(8936002)(6486002)(26005)(8676002)(66946007)(186003)(31696002)(86362001)(5660300002)(4744005)(38100700002)(54906003)(110136005)(7366002)(508600001)(7416002)(7406005)(31686004)(16576012)(316002)(83380400001)(2616005)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejRLUFRablBrbDkxM3VNQmxpSWZwWk1aMUNDdmJlNVptcXI0SFRCLys3YlVM?= =?utf-8?B?dWRBWHBPdWdxVkdva2xkYVEyN3dGZXB3cC9FazRIM1psdVVRVUVHaUFjMTJ1?= =?utf-8?B?blFoeVlCYlFzK2VCSk9BUXZSOXpyQjI2R01nMGtsYmpKaVk2d0RJU2dtMi9j?= =?utf-8?B?cHlHcENNeDlkVWdYQ2loWk9qSDc2QjgrKzJCWC8rSnZYbTlFVTRMSDVsSm80?= =?utf-8?B?Q2p1RnhBcEFwT1RWOVRGVkhOWktGaVRGZE9EY0E5ZlY3VUpJT0RLSnN4a2sr?= =?utf-8?B?Q2tpUElqT3MyWHlwOE1jMlhyOEtUUXRoTThxNVZvcWppSmpVWHBjZGpadDBr?= =?utf-8?B?Z1Aydk5DOEUrbTA2dkRwQStpYTk5MFh1U3NMMzNsUnMxdnp3dVE1L0hEdTZ5?= =?utf-8?B?RzgwREEzQkdNelFyZklGQ2I0OHJmM29MZC9JUnNjUzkxNFNEUFVzTHQydDJQ?= =?utf-8?B?WlZVNm43ZDZNbXdTYTB5UGdpTC9oWnNnK3RPaUdnYlk0TVdUWFpjTDZXY1pC?= =?utf-8?B?UEcveHFvNFZQcTFTeURncUFkRGJrUDFGaDRyTFpJR28yS3VBU0lOMEV3SmNs?= =?utf-8?B?dnYvVnp2V2UzaGRzOU11bitJcG1OL0cvL0Rvc1l6b3U4ekZ5ZzFXVE5sYWxp?= =?utf-8?B?aFkxN2g2ZDhOWml0Y0hVcWZad0NhYzl5dGdIQkJFTktLaFJVWWhpVS9xakJL?= =?utf-8?B?bmJDWUtJcmNTbkEzeW95N29Od0pxNkJHQnk0aTVBbTlhQ0pPRE81ZCtYYzFX?= =?utf-8?B?UUY3c3UrMGRBcW1iU1pTMk1ESnJybjRhbkM1MzF1SnNhSnhCVnpGWEFCSVRU?= =?utf-8?B?T1hxRmViUUJzSVZtY3Q2aDI0ZmdMbThiMUxOWkZWbGI4QSthM3hLMHdhcHh3?= =?utf-8?B?TFZQeXBYc3YxSnFsNXRTUU92RlZFMlU5SkU3SFdGZ0xjZCtEY2pZZ3prcjlk?= =?utf-8?B?b2pra0Q0UTljVHJtdmp1cTd4bGt5ZnZrR3k2eDBieUlLOGdXYzcrb3p4RnFn?= =?utf-8?B?T0JhYnBhdGhZdWhHM1FEVVYvVW8vOTY4bXhNWXZCR2N2OWU2dmtDbzNsOHVB?= =?utf-8?B?cTkyTVVVaFZUU09wWEFRQlZRWW1xN3c4RUdGaE9IRDJ1bW96aDRQcVNDTUlm?= =?utf-8?B?cXc0dS94dzJoWXR6R2dxYWlUUm1BcEhRVWJQV2VEMEZRWFRVUGZnSUtQazIy?= =?utf-8?B?akdjZUhCRnpzSlp0TlF6Nk1jMHFWNXRORExGS3ZGYml3Mkl5UkpkeFl6WFdz?= =?utf-8?B?TXRKS3F4TnllUnN5K0JhOFp3MGN0YnFDTmVjdzZiSGlhaDVJRXpFOGpNWGhh?= =?utf-8?B?N2J2Rk05UDJ6dzlCeHkzZ2ZMYldOZEwyRVRTRTE4QnhwQXhVM05WTXQyQ0dI?= =?utf-8?B?V2Q2UTRIUW1kWTJHUUJLaVRtc1VZWjlWRHdESTE5eHVZTkp4QVBXYkJwWWZn?= =?utf-8?B?MVY4QnNIMjRLbS9TYUh3bXhsTnlwcEtLK3YzdjllV1luMU5kYU1aUThFMG9t?= =?utf-8?B?cXFkTTFEN0dSK3ViUnZsbXJNU0tDN253dm9PdEpXNVcrMCs2L21JNmdKSHkv?= =?utf-8?B?bDJUMlFyWWx3MEZhejNwR3ptUmFDRGtqSzF0NWxWZ0VUQkx2N2hpcTRYQjk2?= =?utf-8?B?Rk55WENHcXFIZXV5K3BPWWRTQW84TTdZdS90OFg5Zlk5cEgzenJBb3hZUE1m?= =?utf-8?B?VTVSVXZxbWc4YnU2MW9HS3pMVFpZQkJ6bVhPekdZTFczYlBHVFBvbTEvSzRC?= =?utf-8?Q?rckt0EfiLVVoSymWiWPcsKNEMc5o1dlO8T//ifX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 75704400-778d-4e5b-9821-08d98cb8bebb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:12:15.8730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MrIQDRKPJOvbQB5ruarYddmLSG+aXMh0npxlHueayG7BRFOVAxWZtJjPCegUqZLl9nwS/cirnuM26M5eDnZS5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5144 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 2/2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/2021 9:28 AM, Thomas Monjalon wrote: > 06/10/2021 13:18, Xueming Li: >> --- a/drivers/net/szedata2/rte_eth_szedata2.c >> +++ b/drivers/net/szedata2/rte_eth_szedata2.c >> static void >> -eth_tx_queue_release(void *q) >> +eth_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) >> { >> - struct szedata2_tx_queue *txq = (struct szedata2_tx_queue *)q; >> + struct szedata2_tx_queue *txq = dev->data->tx_queues[qid]; >> >> if (txq != NULL) { >> if (txq->sze != NULL) >> szedata_close(txq->sze); >> rte_free(txq); >> + dev->data->tx_queues[i] = NULL; >> } >> } > > Compilation is broken. I will do following change in the patch on main: > > - dev->data->tx_queues[i] = NULL; > + dev->data->tx_queues[qid] = NULL; Thanks for catching, fixed in next-net too.