From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED23A0567; Sun, 26 Jun 2022 23:30:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F4EE41141; Sun, 26 Jun 2022 23:30:11 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 4E70D40E50; Sun, 26 Jun 2022 23:30:09 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 052B05C0178; Sun, 26 Jun 2022 17:30:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Jun 2022 17:30:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656279009; x= 1656365409; bh=ig3B5S5qb0oSLXmn1gDlFsAMq6t4hQOiKBYRosHYvmQ=; b=V 9HtIx1t/Su/pnvgBxQ5Swxe/z2Ty84ZUeVln64quD9ZTmojC7sVt86WrOS+5Um+8 2L1CXdB3SOGQx0gJ4WR4z59rvUGJ7hsbtWkpexWeZsnt2dmck51fQlb2N3wP4Qjo ZEd8enCeJysq/DM0DxGzEwUeV2DZfUgWU9pPISLOlSB5wlAT+InDv3COIMC2YwQD oZW5WvUWvRxfO6YofL4dS7oMLvmvSsD9nWhIMFq9s+p+HTQUjB/ksWGhuyM7wRUn /7heHM3m0C6WE9tOxuGBrb4Yj0PB/npde+ePKMbv0izCTjZqsMFhYcEsBbwilL9U tVTpjcw8ddPRLgyxwxCWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656279009; x= 1656365409; bh=ig3B5S5qb0oSLXmn1gDlFsAMq6t4hQOiKBYRosHYvmQ=; b=j k25MqQXBlSaR5ZcMC27TZ5KHSBCSVI5UsLbaWOwuz76jULezTp7/BAQ4ws1NuMAO jNe5gGJ3zvXol/l6ARgG9R0tv6LjMsAE8r62Ek6WG3UlzMg8DO9iaYm5yxUVAhq9 /mbZpPGw6+PngXgNvQCcB09vX5rlbAc+EFkyQXCNNrgq2kpjCAqNm4r8QsDAzJ0X RDrpg9VQvNJVUQVdlbSriim7VkZRD/O5qyJ6bP8d9KKz5WDOE2b8RiKIJbUAKdNL n7mSyj3e1EQnNEzriVfuMXYLapfNaeip3XrnVpZ54FOV4eQ0LrVaqvUFwxHG8HXM Ryr7v230tZCt9+7+GOFuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhtedu udevtdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 17:30:07 -0400 (EDT) From: Thomas Monjalon To: Abdullah =?ISO-8859-1?Q?=D6mer_Yama=E7?= Cc: Ferruh Yigit , stable@dpdk.org, dev@dpdk.org, David Marchand , "Hunt, David" Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor Date: Sun, 26 Jun 2022 23:30:06 +0200 Message-ID: <3588515.MzOyzyC30C@thomas> In-Reply-To: References: <20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/06/2022 10:44, Hunt, David: > On 20/06/2022 18:10, Ferruh Yigit wrote: > > On 6/20/2022 5:31 PM, Abdullah =D6mer Yama=E7 wrote: > >> This patch fixes the syntax error when using the single-core > >> for both rx and distributor functions. > >> > >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Abdullah =D6mer Yama=E7 > > > > Acked-by: Ferruh Yigit > > > > Can we convert compile time macro to dynamic configuration to prevent=20 > > build errors like this? >=20 > +1 for the dynamic config. Maybe a "-c" on the command line for "combine= =20 > rx and dist threads"? >=20 > Tested-by: David Hunt Applied this fix, thanks. Improvement with dynamic option can come later.