From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1749723C
 for <dev@dpdk.org>; Wed, 25 Apr 2018 09:54:10 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A21F920EDD;
 Wed, 25 Apr 2018 03:54:09 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 25 Apr 2018 03:54:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=kAb5JEfkCbpIvCgIYkAue2q3Ac
 KL7XYKad/RYQYKONo=; b=QJSJI5OlTtv6fnBlBdGQZ1aBGF4wqf2wOU37i2FPfT
 LVlFveyY8NCiMX1gJ7UIKufQP2dgFpKNg7/DRWgQSubpRmoHt34Q+AZt6IgiuGVl
 wsFGTnIPdqzVsKHGdkVeOnu2aMoZELMAZ+yE/rhIeEI/uRSajbaIwS3LtuWz4uyX
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=kAb5JE
 fkCbpIvCgIYkAue2q3AcKL7XYKad/RYQYKONo=; b=i/w0e84WW8K7VBsp8U6I2l
 39O3wlbBId+VaZ3ZH4Ol+/erVTpm6dSdID2BpOv3RUBAv3yaSl1Z06wvDCsqhnBh
 YLT0ldS5b+EP/G5PdL6D2MC5vEcGPj3bbxLJF0Ozgiygabd4NglqQ/1mFls++nHV
 fSV9lQCMywGoWayqP9F1O2RmEpUyctiQZnHSGVSb4wUdLVt9j451CsO4kDKm+C5g
 s6Ffun2mmPOpRBfsROSUxPx9EMCQKOHC+uzD6tm/aJeFZi1ZDWXYNcmNwSWBVgPB
 DZ3dKNkYWlXhOW/zHSb3GGHvbK+Q1/gJvSIQ1ByLn8uhjrBQk4127VDYP5rxGGSA
 ==
X-ME-Sender: <xms:ITTgWjL8ufo8oKP-PYwNq1ZvnfAftExWmIOFMm80YNkL0FhYQz1N9Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 788AFE509C;
 Wed, 25 Apr 2018 03:54:08 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Doherty, Declan" <declan.doherty@intel.com>
Date: Wed, 25 Apr 2018 09:54:07 +0200
Message-ID: <3588521.VWcPbH3XqV@xps>
In-Reply-To: <039ED4275CED7440929022BC67E70611531A7E9E@SHSMSX103.ccr.corp.intel.com>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
 <2014014.MPIIikSFdI@xps>
 <039ED4275CED7440929022BC67E70611531A7E9E@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 07:54:10 -0000

25/04/2018 07:33, Zhang, Qi Z:
> > 10/04/2018 15:59, Thomas Monjalon:
> > > > --- a/lib/librte_ether/rte_ethdev.h
> > > > +++ b/lib/librte_ether/rte_ethdev.h
> > > > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred
> > setup
> > > > +rx queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002
> > /**<
> > > > +Deferred setup tx queue */
> > >
> > > Please use RTE_ETH_ prefix.
> 
> Actually I saw all the offload flag is started with DEV_, so
> Should I still need rename to RTE_ETH_DEV_CAPA_***? 

Yes
The flags starting with DEV_ will be managed later because it is hard
to rename an existing flag. It is in my roadmap.
The idea is to not add new flags with wrong namespace prefix.