DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 0/3] fix miss input validation
Date: Fri, 2 Apr 2021 10:59:06 +0800
Message-ID: <3591ef87-5752-7fdf-423b-794c3ad12fba@huawei.com> (raw)
In-Reply-To: <d526d0fd-9c4d-c22d-7a8f-aa5790aa8db4@intel.com>



在 2021/4/1 23:37, Ferruh Yigit 写道:
> On 3/27/2021 7:38 AM, Min Hu (Connor) wrote:
>> The validity verification of input parameters should be performed at
>> API layer, not in the PMD.
>>
>> This set of patches fix miss input validation.
>>
>> Chengchang Tang (3):
>>    ethdev: fix miss input validation in module EEPROM dump API
>>    ethdev: fix miss input validation when access reg info
>>    ethdev: fix miss input validation when access EEPROM info
>>
> 
> The function updated in ethdev header file, and the ethdev .c file seems 
> mixes within the patches [1], can you please send a new version to fix 
> it, you can keep the acks to this version.
> 
> [1]
> 1/3:
> * in .h: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_set_eeprom()'
> * in .c: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_get_module_eeprom()'
> 
> 3/3:
> * in .h: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_get_module_eeprom()'
> * in .c: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_set_eeprom()'
> .
Thanks Ferruh,
   Fixed done in v2.

  reply	other threads:[~2021-04-02  2:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:38 Min Hu (Connor)
2021-03-27  7:38 ` [dpdk-dev] [PATCH 1/3] ethdev: fix miss input validation in module EEPROM dump API Min Hu (Connor)
2021-04-01 15:15   ` Ferruh Yigit
2021-03-27  7:38 ` [dpdk-dev] [PATCH 2/3] ethdev: fix miss input validation when access reg info Min Hu (Connor)
2021-04-01 15:15   ` Ferruh Yigit
2021-03-27  7:38 ` [dpdk-dev] [PATCH 3/3] ethdev: fix miss input validation when access EEPROM info Min Hu (Connor)
2021-04-01 15:27   ` Ferruh Yigit
2021-04-01 15:37 ` [dpdk-dev] [PATCH 0/3] fix miss input validation Ferruh Yigit
2021-04-02  2:59   ` Min Hu (Connor) [this message]
2021-04-02  2:58 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-02  2:58   ` [dpdk-dev] [PATCH v2 1/3] ethdev: fix miss input validation in module EEPROM dump API Min Hu (Connor)
2021-04-02  2:58   ` [dpdk-dev] [PATCH v2 2/3] ethdev: fix miss input validation when access reg info Min Hu (Connor)
2021-04-02  2:58   ` [dpdk-dev] [PATCH v2 3/3] ethdev: fix miss input validation when access EEPROM info Min Hu (Connor)
2021-04-06  7:53   ` [dpdk-dev] [PATCH v2 0/3] fix miss input validation Ferruh Yigit
2021-04-07 22:28     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3591ef87-5752-7fdf-423b-794c3ad12fba@huawei.com \
    --to=humin29@huawei.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git