From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 79A6AA0548;
	Fri,  2 Apr 2021 04:59:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 64ED240F35;
	Fri,  2 Apr 2021 04:59:11 +0200 (CEST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
 by mails.dpdk.org (Postfix) with ESMTP id 7A01740150
 for <dev@dpdk.org>; Fri,  2 Apr 2021 04:59:09 +0200 (CEST)
Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60])
 by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FBPp40B7WznXwc;
 Fri,  2 Apr 2021 10:56:28 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id
 14.3.498.0; Fri, 2 Apr 2021 10:59:06 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
CC: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>
References: <1616830688-65506-1-git-send-email-humin29@huawei.com>
 <d526d0fd-9c4d-c22d-7a8f-aa5790aa8db4@intel.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <3591ef87-5752-7fdf-423b-794c3ad12fba@huawei.com>
Date: Fri, 2 Apr 2021 10:59:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <d526d0fd-9c4d-c22d-7a8f-aa5790aa8db4@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH 0/3] fix miss input validation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



在 2021/4/1 23:37, Ferruh Yigit 写道:
> On 3/27/2021 7:38 AM, Min Hu (Connor) wrote:
>> The validity verification of input parameters should be performed at
>> API layer, not in the PMD.
>>
>> This set of patches fix miss input validation.
>>
>> Chengchang Tang (3):
>>    ethdev: fix miss input validation in module EEPROM dump API
>>    ethdev: fix miss input validation when access reg info
>>    ethdev: fix miss input validation when access EEPROM info
>>
> 
> The function updated in ethdev header file, and the ethdev .c file seems 
> mixes within the patches [1], can you please send a new version to fix 
> it, you can keep the acks to this version.
> 
> [1]
> 1/3:
> * in .h: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_set_eeprom()'
> * in .c: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_get_module_eeprom()'
> 
> 3/3:
> * in .h: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_get_module_eeprom()'
> * in .c: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_set_eeprom()'
> .
Thanks Ferruh,
   Fixed done in v2.