From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D8161BDFE; Fri, 21 Dec 2018 00:51:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E8F4621C4F; Thu, 20 Dec 2018 18:51:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 18:51:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=fOOb/zXmfj0SkFAYqiZKQT9OdwnVzQRhNi53GME2YRs=; b=sEL4nTALIXyn zLLK+3GL41dOUE1wfNoo58HCOsb1+9/4u0WsWySQKuVMnetlo58Od4Z7FKjtGslP GSWZdkxk9P9UAdI5ZgchdC2En+ueeaB7mfDLbA2ogk93Q/uzjrsIJccm5443LJw0 oFZtKYpcSYWtla6h+hkFlFPisGlAYmA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fOOb/zXmfj0SkFAYqiZKQT9OdwnVzQRhNi53GME2Y Rs=; b=fwN7/Poy+kpVGTHBU3+N0UhQi9jt5rx277p/nx/boq3bf2Zz4ew+QiEBo aNchJ+oybsOtNRN0h4Ow0F+XLLi4j8GcAClTLoNEMMP83VQ0u+TjV01g6J4OxsPQ hYrIV+C9DEenux6yj2JUfGyb/PQfN5BiDMPrapOd+qsWlME/aZ4GgJuzUBoZHiA/ g6lX6+DDrOvs65HIDvMeqdl5KIBDUmz9KoZgRRBZQF6IGVmdGFvghfq4SwSoPBNh ffNgY/pENTG+mlnhI41zb+lxEECxlZnj3gySuqR6zWyrE/nNG/k+OkdzYAdWP/RA 46c2B4G3te/LpX1vIpeIAv3e0c9KA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejgedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EDF14E4366; Thu, 20 Dec 2018 18:51:27 -0500 (EST) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org Date: Fri, 21 Dec 2018 00:51:26 +0100 Message-ID: <35952782.MrcKBpYm8b@xps> In-Reply-To: <20181219115950.46386-1-bruce.richardson@intel.com> References: <20181219115950.46386-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error when using ports of different types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 23:51:29 -0000 19/12/2018 12:59, Bruce Richardson: > Different NIC ports can have different numbers of xstats on them, which > means that we can't just use the xstats list from the first port registered > in the telemetry library. Instead, we need to check the type of each port - > by checking its ops structure pointer - and register each port type once > with the metrics lib. > > CC: stable@dpdk.org > Fixes: fdbdb3f9ce46 ("telemetry: add initial connection socket") > > Signed-off-by: Bruce Richardson Kevin, any comment please?