From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9AD7E2BD5 for ; Mon, 16 Jul 2018 01:12:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3B48620964; Sun, 15 Jul 2018 19:12:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 15 Jul 2018 19:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=xxzNeshE/a5MAUjhmw8zUBquwo ANSHdECZADc9s3G8w=; b=TwUBkC4qrqf/T69VMosddMChzsjmlwQqJBhaAldZYI cVyRbtMZ7CuWSYhLuurpjrx0Gi/o9KUf63jnyUN8gmAGX0ALIe/YS2KyUOR86jGr rN7IpsuLOe8CvyerJlEnGSJ+Zq3iMVdnwGrABM38Mxf9UpgQW7CRS4pYOhyLEsnf Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=xxzNes hE/a5MAUjhmw8zUBquwoANSHdECZADc9s3G8w=; b=ojpmQspEyk3qm/9tI6k1ac IxXAWTjrHH078StPv6X2oJloD2Bysc1QCjOUIfajh+F1rRDlosHlfmxDB+VUBaiD d9r5tIlajJcu7aDM38jJVsBBvyEnCU2XNCjEXl/phHXTeWvUmsJwJH0TgJI93A08 pwexMB2fmtd86pbg52TqZysf88oNen+G+J/PqCIpo0yh9Eqg7nVgDO2A0ofDnbT2 a0V6VqfcHMcqdDicWjuUJ4VZITpEHqea2VMEky0OU32eu4WsGk+NVfEHlIlUk/oI RbzKDQIE1xOhq8lDtb+zbMsxcTcoCAOCn6DC1RKH2V09f2jtLSy5yUBR5PmakIrw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [31.154.190.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A12DE450F; Sun, 15 Jul 2018 19:12:46 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit , Stephen Hemminger Date: Mon, 16 Jul 2018 01:12:38 +0200 Message-ID: <3596307.7gyfprgr2O@xps> In-Reply-To: <20180627180101.16442-1-nhorman@tuxdriver.com> References: <20180115190545.25687-1-nhorman@tuxdriver.com> <20180627180101.16442-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 23:12:50 -0000 27/06/2018 20:01, Neil Horman: > Recently, some additional patches were added to allow for programmatic > marking of C symbols as experimental. The addition of these markers is > dependent on the manual addition of exported symbols to the EXPERIMENTAL > section of the corresponding libraries version map file. The consensus > on review is that, in addition to mandating the addition of symbols to > the EXPERIMENTAL version in the map, we need a mechanism to enforce our > documented process of mandating that addition when they are introduced. > To that end, I am proposing this change. It is an addition to the > checkpatches script, which scan incoming patches for additions and > removals of symbols to the map file, and warns the user appropriately > > Signed-off-by: Neil Horman > CC: thomas@monjalon.net > CC: john.mcnamara@intel.com > CC: bruce.richardson@intel.com > CC: Ferruh Yigit > CC: Stephen Hemminger > > --- > + tmpinput=$(mktemp checkpatches.XXXXXX) > + git format-patch --find-renames \ > + --no-stat --stdout -1 $commit > ./$tmpinput In case $tmpinput is an absolute path (like in /tmp), we must not prepend it with ./ I fix it when applying. Applied, thanks