From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6918A548B for ; Wed, 3 Apr 2019 00:39:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ED92021BAD; Tue, 2 Apr 2019 18:39:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:39:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=912Vaz1HR4YGqoleobDyaKFqzKdZZ0Nh9AgBs/XdP7E=; b=NjroHpT6mNP5 7Ckz/1LcD7jaoJxTbHBpJEqwTaB+JgM+plkFYdsWLgxZ9IGSmcZ+Pdlqh6OgIMKt c3EPzXZTp5VA/Q0iN+NQc+8AiCQInTxh1MCgJrTztNVsMzuzO3waQu6LZVMdbHSc q1EtQ1DgjLpWZVpoodEz7C+bauoyZP0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=912Vaz1HR4YGqoleobDyaKFqzKdZZ0Nh9AgBs/XdP 7E=; b=3tD5LKNBc8n94b4Tvp4chovK2VoiXBHLPwV7k9njIVVntR/EaEERnLoX/ 4n6ucCw1FUuToD5ZEhvAk4VAhEnA1PcfvG2jzgRUtIk41HRvJQz8Q0hSAla2KB7f kjIsf/Cwu//Z5gGQmus0Pos9fTeDERe26sqmXCxRdLDGoUaXCCeKcPnN0jFpXtFZ 6GB1hrVcmJwwaw3Kts0jCZ3b66J8RgoLyN7SlPUZpDNGupAFdldpSggSali9X3hA bSxNJgTrKRDkaMiusjdeOSkNeoWL6AHYk/hv3aCe3ZIaTEsxLlQik3bVjnG16X/E eGhVdaf2Rati/qSXE6IV7Pupq+f6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugdduudculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A170210316; Tue, 2 Apr 2019 18:39:12 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com Date: Wed, 03 Apr 2019 00:39:11 +0200 Message-ID: <3599974.brf36yD2AO@xps> In-Reply-To: <20190402035458.14664-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 22:39:15 -0000 I think the change below is bad because it is exposing an internal function in a header file which may be included by apps. I know you are still looking for pthread integration solutions, so we can discuss how to fix it later. Note that there is already an EAL function to create normal threads: rte_ctrl_thread_create() You may want a similar function for dataplane threads perhaps. 02/04/2019 05:54, Anand Rawat: > --- a/lib/librte_eal/windows/eal/include/rte_os.h > +++ b/lib/librte_eal/windows/eal/include/rte_os.h > @@ -15,7 +15,9 @@ > extern "C" { > #endif > > +#include > #include > +#include > > #define strerror_r(a, b, c) strerror_s(b, c, a) > > @@ -26,6 +28,24 @@ typedef SSIZE_T ssize_t; > > #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr) > > +/** > + * Create a thread. > + * This function is private to EAL. > + * > + * @param thread > + * The location to store the thread id if successful. > + * @return > + * 0 for success, -1 if the thread is not created. > + */ > +int eal_thread_create(pthread_t *thread); > + > +/** > + * Create a map of processors and cores on the system. > + * This function is private to EAL. > + * > + */ > +void eal_create_cpu_map(void); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CA730A0679 for ; Wed, 3 Apr 2019 00:39:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B74B55920; Wed, 3 Apr 2019 00:39:17 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6918A548B for ; Wed, 3 Apr 2019 00:39:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ED92021BAD; Tue, 2 Apr 2019 18:39:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:39:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=912Vaz1HR4YGqoleobDyaKFqzKdZZ0Nh9AgBs/XdP7E=; b=NjroHpT6mNP5 7Ckz/1LcD7jaoJxTbHBpJEqwTaB+JgM+plkFYdsWLgxZ9IGSmcZ+Pdlqh6OgIMKt c3EPzXZTp5VA/Q0iN+NQc+8AiCQInTxh1MCgJrTztNVsMzuzO3waQu6LZVMdbHSc q1EtQ1DgjLpWZVpoodEz7C+bauoyZP0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=912Vaz1HR4YGqoleobDyaKFqzKdZZ0Nh9AgBs/XdP 7E=; b=3tD5LKNBc8n94b4Tvp4chovK2VoiXBHLPwV7k9njIVVntR/EaEERnLoX/ 4n6ucCw1FUuToD5ZEhvAk4VAhEnA1PcfvG2jzgRUtIk41HRvJQz8Q0hSAla2KB7f kjIsf/Cwu//Z5gGQmus0Pos9fTeDERe26sqmXCxRdLDGoUaXCCeKcPnN0jFpXtFZ 6GB1hrVcmJwwaw3Kts0jCZ3b66J8RgoLyN7SlPUZpDNGupAFdldpSggSali9X3hA bSxNJgTrKRDkaMiusjdeOSkNeoWL6AHYk/hv3aCe3ZIaTEsxLlQik3bVjnG16X/E eGhVdaf2Rati/qSXE6IV7Pupq+f6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugdduudculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A170210316; Tue, 2 Apr 2019 18:39:12 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com Date: Wed, 03 Apr 2019 00:39:11 +0200 Message-ID: <3599974.brf36yD2AO@xps> In-Reply-To: <20190402035458.14664-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402223911.Wnr_FxjKSN4V0LbVoP1NdzSyuLqfeQk_WyzgebA5kUU@z> I think the change below is bad because it is exposing an internal function in a header file which may be included by apps. I know you are still looking for pthread integration solutions, so we can discuss how to fix it later. Note that there is already an EAL function to create normal threads: rte_ctrl_thread_create() You may want a similar function for dataplane threads perhaps. 02/04/2019 05:54, Anand Rawat: > --- a/lib/librte_eal/windows/eal/include/rte_os.h > +++ b/lib/librte_eal/windows/eal/include/rte_os.h > @@ -15,7 +15,9 @@ > extern "C" { > #endif > > +#include > #include > +#include > > #define strerror_r(a, b, c) strerror_s(b, c, a) > > @@ -26,6 +28,24 @@ typedef SSIZE_T ssize_t; > > #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr) > > +/** > + * Create a thread. > + * This function is private to EAL. > + * > + * @param thread > + * The location to store the thread id if successful. > + * @return > + * 0 for success, -1 if the thread is not created. > + */ > +int eal_thread_create(pthread_t *thread); > + > +/** > + * Create a map of processors and cores on the system. > + * This function is private to EAL. > + * > + */ > +void eal_create_cpu_map(void);