From: Luca Boccassi <bluca@debian.org>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] ci: catch coredumps
Date: Tue, 02 Mar 2021 16:16:52 +0000 [thread overview]
Message-ID: <35a3fc3ed2d78d0420aa2475b2902e225fab48e0.camel@debian.org> (raw)
In-Reply-To: <20210125150539.27537-1-david.marchand@redhat.com>
On Mon, 2021-01-25 at 16:05 +0100, David Marchand wrote:
> Parts of the unit tests code rely on forked/secondary processes
> (expectedly) failing.
> A crash in those situations could be missed so add a check on coredumps
> presence after unit tests have run.
> When unit tests fail, it can also help checking for coredumps as it
> could give more insights on what happened.
>
> In some situations (like explicit call to rte_panic), coredump generation
> must be disabled to avoid false positives.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since RFC v1
> - removed RFC,
> - pushed coredumps into gdb for in-situ analysis,
> - gdb presence is used to enable the check. Travis config is left
> untouched for now,
>
> ---
> .ci/linux-build.sh | 37 ++++++++++++++++++++++++++++++++++---
> .github/workflows/build.yml | 4 ++++
> app/test/test_debug.c | 11 +++++++++--
> app/test/test_mbuf.c | 9 ++++++++-
> 4 files changed, 55 insertions(+), 6 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
This fixes an issue for me, with running the debug_autotest under a
reproducible build CI environment.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2021-03-02 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 10:01 [dpdk-dev] [RFC PATCH] " David Marchand
2021-01-11 13:17 ` Aaron Conole
2021-01-25 15:05 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-03-02 16:16 ` Luca Boccassi [this message]
2021-03-02 21:17 ` Aaron Conole
2021-03-03 9:03 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35a3fc3ed2d78d0420aa2475b2902e225fab48e0.camel@debian.org \
--to=bluca@debian.org \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).